create directory if doesn't exist for submissions download #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skygragon
reviewed
Oct 22, 2017
lib/commands/submission.js
Outdated
| h.langToExt(submission.lang)); | ||
|
|
||
| try { | ||
| fs.statSync(argv.outdir); |
Owner
There was a problem hiding this comment.
better to use fs.existsSync instead?
Owner
|
also would appreciate if you can merge those 2 tiny commits into single one, e.g. you can do it by reseting or rebasing in your local git repo. |
Contributor
Author
|
done |
skygragon
reviewed
Oct 22, 2017
| h.langToExt(submission.lang)); | ||
|
|
||
| if (!fs.existsSync(argv.outdir)) { | ||
| fs.mkdirSync(argv.outdir); |
Owner
There was a problem hiding this comment.
unfortunately this won't create directories recursively, while I think it's good enough for now.
Contributor
Author
There was a problem hiding this comment.
If you want that, I can implement it but I think there is no need for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#68