-
Notifications
You must be signed in to change notification settings - Fork 6
add compatible models in brickinstance details #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Response:GET http://localhost:8080/v1/apps/ZXhhbXBsZXM6aW1hZ2UtY2xhc3NpZmljYXRpb24/bricks/arduino:image_classification |
|
In the |
We discussed it and the answer is yes. |
| Variables map[string]string `json:"variables,omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."` | ||
| ConfigVariables []BrickConfigVariable `json:"config_variables,omitempty"` | ||
| ModelID string `json:"model,omitempty"` | ||
| CompatibleModels []AIModel `json:"compatible_models,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the result of omitempty with a list ?
I expect that the JSON response is `"compatible_models: [] ". We can add a test for it
Motivation
closes #89
When a brick is assigned to an app, the FE must show the list of other compatible models for the installed brick.
For example when a new model is selected for a given brick installed into an app.
Change Description
Additional Notes
Reviewer checklist
main.