Python Input validation

Question

I have a menu that will return 'e' unless the input is d or D. I would like to do it without making another variable and doing it on one line

encrypt = 'd' if (raw_input("Encrypt or Decrypt a file(E/d):") == ('d' or 'D')) else 'e'

[Edit] Ok here is a harder one

How can I do the same for this

file_text = 'a.txt' if (raw_input("File name(a.txt):")=='a.txt' else [What I typed in]

Why one line? It makes your code harder to understand for most people — Bryan Oakley
– Bryan Oakley, Commented Apr 3, 2012 at 19:49
@BryanOakley It looks too drawn out if it is encrypt = raw_input("Encrypt or Decrypt a file(E/d):" if encrypt != 'd' or encrypt != 'D': encrypt != 'e' I also like to look for unusual and different ways to do programing — GeneralZero
– GeneralZero, Commented Apr 3, 2012 at 20:19

Alex Vidal · Accepted Answer · 2012-04-03 20:18:45Z

3

Use the in operator:

encrypt = 'd' if raw_input("Encrypt or decrypt a file (E/d):") in ('d', 'D') else 'e'

Alternatively, you can just convert the input to lowercase and compare it to 'd':

encrypt = 'd' if raw_input("Encrypt or decrypt a file (E/d):").lower() == 'd' else 'e'

Finally, if you want to ensure that they enter e or d, you can wrap it up in a while loop:

while True:
    encrypt = raw_input("Encrypt or decrypt a file (E/d):")

    # Convert to lowercase
    encrypt = encrypt.lower()

    # If it's e or d then break out of the loop
    if encrypt in ('e', 'd'):
        break

    # Otherwise, it'll loop back and ask them to input again

Edit: To answer your second question, you can use a lambda for it I guess?

file_text = (lambda default, inp: default if inp.lower() == default else inp)("a.txt", raw_input("File name(a.txt):"))

Although, this is clearly a bit obtuse and too "clever" by half.

edited Apr 3, 2012 at 20:18

answered Apr 3, 2012 at 19:47

Alex Vidal

4,10822 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Bastien Léonard Over a year ago

You can also try raw_input("...").lower() == 'd'.

Alex Vidal Over a year ago

I was thinking the same thing, but I figured I'd try staying closer to the original snippet.

GeneralZero Over a year ago

@AlexVidal I dont like loops for simple yes or no inputs. Instead I like to check the input if non-default [do stuff] else its the default

katzenversteher · Accepted Answer · 2012-04-03 19:59:40Z

1

Not really meant seriously but another 1-line solution (I don't think it's readable):

encrypt = {'d':'d','D':'d'}.get(raw_input("Encrypt or decrypt a file (E/d):"), 'e')

At least it's short. Sometimes a dictionary is actually useful for similar situations (if there are more choices).

answered Apr 3, 2012 at 19:59

katzenversteher

8106 silver badges14 bronze badges

Collectives™ on Stack Overflow

Python Input validation

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related