PHP using urldecode with regex

Question

I'm trying to use this line of code to accept URL variables with spaces replaced by '%20' but it also has to go through a regex

$type=urldecode(ereg_replace("[^a-zA-Z0-9%]+", "", @$_REQUEST['type']));

The result is just the %20 removed instead of replacing with a space e.g JohnDoe not John Doe, from John%20Doe

Your could would replace everything matching by your regex with nothing (""). — Dion
– Dion, Commented Apr 5, 2012 at 9:53
The superglobals $_GET and $_REQUEST are already decoded. Using urldecode() on an element in $_GET or $_REQUEST could have unexpected and dangerous results. — miqbal
– miqbal, Commented Apr 5, 2012 at 9:54
The answer is $type=ereg_replace("[^a-zA-Z0-9[:space:][:blank:]]+", "", @$_REQUEST['type']); As mentioned it has to go through the regex for other reasons, $_REQUEST is decoded by default — Guesser
– Guesser, Commented Apr 5, 2012 at 10:30

Baba · Accepted Answer · 2012-04-05 09:55:44Z

1

You have the order wrong and note that ereg_replace is depreciated .. preg_replace is a better option

Try

 $type  = ereg_replace("[^a-zA-Z0-9%]+", "", urldecode(@$_REQUEST['type']));

Better Approch

$type = @$_REQUEST['type'] ; 
$type = urldecode($type);
$type = str_replace(" ","",$type) ;

Thanks

:)

answered Apr 5, 2012 at 9:55

Baba

95.3k29 gold badges172 silver badges222 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

anubhava · Accepted Answer · 2012-04-05 09:52:50Z

0

If you are just trying to replace space with %20 then use:

str_replace(" ", "%20", $_REQUEST['type']);

no need to use regex here.

answered Apr 5, 2012 at 9:52

anubhava

790k67 gold badges603 silver badges671 bronze badges

Wrong parameter order. str_replace ( mixed $search , mixed $replace , mixed $subject [, int &$count ] )

Dion · Accepted Answer · 2012-04-05 10:01:34Z

0

$type = str_replace("%20", "", @$_REQUEST["type"]); should work and would replace all %20 by "".

answered Apr 5, 2012 at 9:55

Dion

3,34525 silver badges40 bronze badges