php array not having items?

Question

I have the following code. I am trying to keep track of selected items and display them down from array.

<?php
session_start();

//temp stores the submitted value
$temp = $_POST['field'];

if (!isset($_SESSION['itemsList'])) {
    $itemsList = array();
} else {
    $itemsList = $_SESSION['itemsList'];
}

//check how many elements in array
$arraySize = count($itemsList);

//set that as i and then add after that
$emptyval = "";

if (strcmp($temp,$emptyval)!=TRUE) {
    array_splice($itemsList, $arraySize+1, 0, $temp);
    unset($temp);
    unset($_SESSION['field']);
    $_SESSION['itemList'] = $itemList;
}
?>
<html>
<head>
    <title>Test Page Khalid</title>
</head>
<body>
<form action="<?=$_SERVER['PHP_SELF'];?>" method="post">

    <table height="100%" width="100%" cellspacing="10" cellpadding="10" border="1">
        <tr>
            <td align="center"><input name="field" value="shirt" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="pants" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="socks" style="width:200px; height:100px;" type="submit"/></td>
        <tr>
        <tr>
            <td align="center"><input name="field" value="dress" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="skirt" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="topbody" style="width:200px; height:100px;" type="submit"/></td>
        <tr>
        <tr>
            <td align="center"><input name="field" value="sheets" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="pillowcover" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="blanket" style="width:200px; height:100px;" type="submit"/></td>
        <tr>        
    </table>
</form>
<br><br><br>
<?php
$itemsReturned = $_SESSION['itemList'];
echo "The items stored are: <br>";
print_r($itemsReturned);
?>

</body>
</html>

Any idea why this is not displaying anything? Thanks,

What do you mean 'not displaying anything'? Is nothing coming up at all? — Gricey
– Gricey, Commented Apr 10, 2012 at 13:13
Turning on error reporting will allow people to provide more help. — Jim
– Jim, Commented Apr 10, 2012 at 13:13
Try the everyday debugging stuff, then supply that info: Is it getting into the IF-block where it sets the variable? If so, what's the value immediately after it's set? How about right after the IF-block...etc. — Dave
– Dave, Commented Apr 10, 2012 at 13:14
well the html is but nothing from the items in array...am i doing something wrong in script? — sys_debug
– sys_debug, Commented Apr 10, 2012 at 13:14
In your second if-statement, you are using $_SESSION['itemList'] and $itemList and in other places it's itemsList (looks like you forgot the s in the second if-statement). Also, be careful when setting the action of your form to $_SERVER['PHP_SELF']. This is vulnerable to cross-site scripting. — Travesty3
– Travesty3, Commented Apr 10, 2012 at 13:20

trickyzter · Accepted Answer · 2012-04-11 08:23:15Z

2

Is this what your trying to achieve:

<?php
session_start();
//store submitted value
$val = $_POST['field'];
//create a reference to the session
$items = (!isset($_SESSION['items']) ? array() : $_SESSION['items']);

//did the user submit a value?
if($val){
//append the value to the items array, contained within the session
    $_SESSION['items'][] = $val;
//update the reference
    $items =& $_SESSION['items'];
}

?>
<html>
<head>
    <title>Test Page Khalid</title>
</head>
<body>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">

    <table height="100%" width="100%" cellspacing="10" cellpadding="10" border="1">
        <tr>
            <td align="center"><input name="field" value="shirt" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="pants" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="socks" style="width:200px; height:100px;" type="submit"/></td>
        <tr>
        <tr>
            <td align="center"><input name="field" value="dress" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="skirt" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="topbody" style="width:200px; height:100px;" type="submit"/></td>
        <tr>
        <tr>
            <td align="center"><input name="field" value="sheets" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="pillowcover" style="width:200px; height:100px;" type="submit"/></td>
            <td align="center"><input name="field" value="blanket" style="width:200px; height:100px;" type="submit"/></td>
        <tr>        
    </table>
</form>
<br><br><br>
<?php
echo "The items stored are: <br>";
print_r($items);
?>

</body>
</html>

Can you provide detail as to the purpose of the following:

$emptyval = "";

if (strcmp($temp,$emptyval)!=TRUE) {
    array_splice($itemsList, $arraySize+1, 0, $temp);
    unset($temp);
    unset($_SESSION['field']);
    $_SESSION['itemList'] = $itemList;
}

edited Apr 11, 2012 at 8:23

answered Apr 10, 2012 at 13:20

trickyzter

1,60113 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

trickyzter Over a year ago

I also agree with Travesty3, if using the $_SERVER['PHP_SELF'] superglobal, it needs to be escaped.

sys_debug Over a year ago

well here I am checking if temp is not equal to empty "". if it isnt, then add temp value to array in the next free slot (index), and store the itemsList to session

trickyzter Over a year ago

The function you have used is for comparing string values, this is overkill for just checking a values state. A better method would be the use of uk3.php.net/manual/en/function.empty.php.

sys_debug Over a year ago

I have an issue with the same code exactly. Now when I select an item, it reloads the page (because of self_submit). but the item doesn't appear in the list. THen I choose the same item again, the page loads with the item in list. Then I go an select another item, but what appears in the list this time is the lost entry of first item (as if it was cached and delayed). Any idea what such a thing would happen??

trickyzter Over a year ago

I can't say I've seen an instance of that before. I've updated the code to make use of the $items var set. In addition I forgot to echo out the form action, however the changes shouldn't reflect a functional change. You definitely haven't changed anything? Have you tried in a different browser?

Collectives™ on Stack Overflow

php array not having items?

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related