Javascript function variables issue

Question

What is the problem with my script? When I execute it, the alert (line 2) gives me "100,200,300undefinedundefined", so is seems like 100,200,300 is interpreted as h1 when I would like it to be h1, h2 and h3 (with the commas).

function myanimation(h1,h2,h3) {

        alert(h1 + h2 + h3);
        $("#h1").animate({"left": h1});
        $("#h2").animate({"left": h2});
    }

    var moves = new Array()
    moves[1] = [100,200,300];
    moves[2] = [300,200,100];
    moves[3] = [-500,-300,0];

    var i = 1;

    function animatenow(){
        myanimation(moves[i]);
        i++;
    }

$('#launch').click(function() {
        setInterval(animatenow, 5000);
    });

rosscj2533 · Accepted Answer · 2012-04-19 17:50:23Z

6

You are passing an array into myanimation, which corresponds to your h1 parameter. You aren't passing h2 or h3, so those are undefined.

answered Apr 19, 2012 at 17:50

rosscj2533

9,3437 gold badges41 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Brian Hoover · Accepted Answer · 2012-04-19 17:51:17Z

2

Adam, you are passing in an array object into H1, not separate variables

You probably want to change

myanimation(moves[i]);

to:

myanimation(moves[i][0],moves[i][1],moves[i][2]);

answered Apr 19, 2012 at 17:51

Brian Hoover

7,9652 gold badges31 silver badges41 bronze badges

2 Comments

Adam Strudwick Over a year ago

Another question: when I use i++ in my function, it doesn't work; it always sends moves[1] so how can I make the i++ scope be global instead of local?

Brian Hoover Over a year ago

@AdamStrudwick it's not doing that for me. Could there be some other code that might be resetting i?

jeremyharris · Accepted Answer · 2012-04-19 17:51:19Z

2

You're passing an array to myanimation where it expects three parameters.

myanimation(moves[i]); where moves[1] = [100,200,300]

So h1 in your myanimation would be [100,200,300]

Change it to expect an array:

function myanimation(moves) {
    $("#h1").animate({"left": moves[1]}); // moves[1] is 100
    $("#h2").animate({"left": moves[2]}); // 200
}

answered Apr 19, 2012 at 17:51

jeremyharris

7,88224 silver badges31 bronze badges

Comments

David.Chu.ca · Accepted Answer · 2012-04-19 17:58:20Z

0

Based on your codes, should the following codes like this?

function animatenow(){
    myanimation(moves[i][0], moves[i][1], moves[i][2]);
    i++;
}

answered Apr 19, 2012 at 17:58

David.Chu.ca

39.1k66 gold badges154 silver badges199 bronze badges

1 Comment

Adam Strudwick Over a year ago

Another question: when I use i++ in my function, it doesn't work; it always sends moves[1] so how can I make the i++ scope be global instead of local?

Collectives™ on Stack Overflow

Javascript function variables issue

4 Answers 4

Comments

2 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related