Using java String.format on a android sqlite arguments

Question

Android sqlite commands are like db.delete(table, whereClause, whereArgs); whereClause is a string such as "column1 = ? and column2 = ?" whereArgs is a string array that holds the values that will be substituted in the whereClause. Is there an easy way for me to get the decoded string from this (for logging purposes). String.format seems close, but not quite. This is what I am aiming for:

 Log.e(MY_DEBUG_TAG, 
     "Error executing Delete(" + table + ", " + 
            String.format(whereClause, whereArgs + ")");

Why would you want to make yourself vulnerable to SQL injection attacks (or work out all the quoting required) rather than using a parameterized query in the normal way? — Jon Skeet
– Jon Skeet, Commented Jun 1, 2012 at 20:06
I am using the parameterized query. It's just that when I have a problem, I want to read the logs and see what it was that I was trying to do. string[].ToString() doesn't give any useful information about the strings in the array, so I want to know how to turn the arguments into an easily read string. — MrGibbage
– MrGibbage, Commented Jun 1, 2012 at 20:13
I do apologise - I missed the fact that this is just for logging. I would personally just log the parameterized SQL and log the parameters separately. — Jon Skeet
– Jon Skeet, Commented Jun 1, 2012 at 20:18
What I am asking is that when there is an error, the stack trace shows the complied query. It looks like a reqular SQL query, in a nice human-readable form. I would like to log the query with the same format. But converting the whereclause and whereargs into a friendly string seems tedious. I was hoping there was an easy way. String.format comes to mind, but it isn't quite right. — MrGibbage
– MrGibbage, Commented Jun 1, 2012 at 20:23

Diego Torres Milano · Accepted Answer · 2012-06-01 20:32:41Z

2

If only for logging purposes you may try:

 Log.e(MY_DEBUG_TAG, 
     "Error executing Delete(" + table + ", " + 
            String.format(whereClause.replaceAll("\\?", "%s"), (Object[])whereArgs) + ")");

edited Jun 1, 2012 at 20:32

answered Jun 1, 2012 at 20:21

Diego Torres Milano

69.9k9 gold badges116 silver badges145 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

MrGibbage Over a year ago

I get this warning "The argument of type String[] should explicitly be cast to Object[] for the invocation of the varargs method format(String, Object...) from type String. It could alternatively be cast to Object for a varargs invocation" How do I make that go away?

Collectives™ on Stack Overflow

Using java String.format on a android sqlite arguments

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related