Accept Multiple inputs with php to update a mysql database

Question

I'm working on a small project: a small number crunching game.

I want to have a php file that can accept inputs and interpret them into specified database updates.

Here is what I have so far. It doesn't seem to be working for me.

$name = $_GET['n'];
$action = $_GET['a'];
$result = mysql_query("SELECT * FROM players WHERE Username ='".$name."'");

while($row = mysql_fetch_array($result)) {
  if ($action = "rankup") mysql_query("UPDATE players SET Level 'Level+1' WHERE Username='".$name."'");
}

mysql_close($con);

I'm not getting any errors, but its not working, and all the database connections are fine.

I dont know what the problem is.

At first please use mysql_real_escape_string($_GET['foo']) for every user input you pass to the DB. Second, you should use the more "modern" way of accessing the DB with PHP PDO (see php.net/pdo). — fdomig
– fdomig, Commented Jul 11, 2012 at 21:57
First of all the database functions you are using are obsolete. You should use mysqli_query and mysqli_close not mysql. — DrinkJavaCodeJava
– DrinkJavaCodeJava, Commented Jul 11, 2012 at 21:57

Ugo Méda · Accepted Answer · 2012-07-11 22:00:26Z

2

Several mistakes here :

You're not sanitizing your inputs, please read about SQL Injections
You're not checking the output of your mysql_query. The query with SET Level 'Level+1' is invalid, you forgot a = and remove quotes
$action == 'rankup', not =
Please consider using PDO for new projects, it's a way better interface than mysql_ functions.

answered Jul 11, 2012 at 22:00

Ugo Méda

1,2159 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

DrinkJavaCodeJava · Accepted Answer · 2012-07-11 22:09:10Z

1

You want to enter your sql query like this

'UPDATE players SET Level= (Level+1)  WHERE Username='.$name.'

Also any database function that begins with mysql should be replaced with mysqli. This is because PHP is phasing out functions beginning with mysql in the next edition.

edited Jul 11, 2012 at 22:09

answered Jul 11, 2012 at 22:03

DrinkJavaCodeJava

8089 silver badges22 bronze badges

Collectives™ on Stack Overflow

Accept Multiple inputs with php to update a mysql database

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related