multiple mysql queries into one php two-dimensional array

Question

I'm refactoring my code and just hit a snag. The first query in the code below gets the tab_id of the latest submitted tabs. The second Query gets the detail of each tab. In my old way of doing it, i embedded php and html and it was truly an utter mess. Right now I'd like to merge the 2 queries into 1 and/or load it into an array.

feel free to ask and/or butcher

function get_newest_tabs()
{
    $db_open;
    $sql = "SELECT tab_id, song_id, user_id FROM tabs ORDER BY time_added DESC ". "LIMIT 15";
    $result = mysql_query($sql) or die("ERROR - newest tabs function: ".mysql_error());

    if (mysql_num_rows($result) > 0)
    {
        for($i = 0; $i < mysql_num_rows($result); $i++)
        {
            $tab_id = mysql_result($result, $i, "tab_id");
            $db_open;
            $sql =  
                "SELECT tabs.tab_id, tabs.tab_version, tabs.number_of_hits, artist.artist_name, users.user_alias, songs.song_name, tabs.time_added
                FROM tabs, users, artist, songs
                WHERE tabs.tab_id ='".$tab_id."'  AND tabs.user_id = users.user_id AND tabs.song_id = songs.song_id AND songs.artist_id = artist.artist_id";
            $result2 = mysql_query($sql) or die("ERROR - i3p mysql - 4: ".mysql_error());

            if(mysql_num_rows($result2) == 1)
            {
                $song_name = mysql_result($result2, 0, "songs.song_name");
                $artist_name = mysql_result($result2, 0, "artist.artist_name");
                $user_alias = mysql_result($result2, 0, "users.user_alias");
                $tab_version = mysql_result($result2, 0, "tabs.tab_version");
                $number_of_hits = mysql_result($result2, 0, "tabs.number_of_hits");
                $time_added = mysql_result($result2, 0, "tabs.time_added");

            }
        }
    }
}

This link may be of interest. Explains why using mysql_num_rows may not be the best thing. stackoverflow.com/questions/1165298/… — Smandoli
– Smandoli, Commented Jul 23, 2009 at 15:07

dmertl · Accepted Answer · 2009-07-23 14:56:35Z

3

I'd suggest using JOIN instead of selecting from multiple tables. You can also join the tabs table.

SELECT tabs.tab_id, tabs.song_id, tabs.user_id, tabs.tab_version, tabs.number_of_hits, artist.artist_name, users.user_alias, songs.song_name, tabs.time_added
FROM tabs
LEFT JOIN users ON users.user_id = tabs.user_id
LEFT JOIN songs ON songs.song_id = tabs.song_id
LEFT JOIN artist ON artist.artist_id = songs.artist_id
ORDER BY tabs.time_added DESC LIMIT 15

Then you could do a loop like:

while($row = mysql_fetch_array($result)) {
$tabs[$row['tab_id']] = $row;
}

As long as you have one user/song/artist per tab that will get you an array of your data.

answered Jul 23, 2009 at 14:56

dmertl

8358 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

hegemon · Accepted Answer · 2009-07-23 14:49:49Z

0

Why not use sql:

WHERE tabs.tab_id IN (1,2,3,4)

or event

WHERE tabs.tab_id in (select tab_id from tabs ... )

I think it's rather SQL related question.

answered Jul 23, 2009 at 14:49

hegemon

6,8242 gold badges34 silver badges31 bronze badges

Comments

Smandoli · Accepted Answer · 2009-07-23 14:56:02Z

0

I'm not sure how to read hegemon's suggestions, but AGREED it's an SQL question. That means you should do all your work in a MySQL interface without PHP in the way, then bring the finished SQL strings in. I use phpMyAdmin, which has a convenient feature that formats the SQL for use in PHP.

answered Jul 23, 2009 at 14:56

Smandoli

7,0593 gold badges53 silver badges83 bronze badges

Collectives™ on Stack Overflow

multiple mysql queries into one php two-dimensional array

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related