Adding objects from array to dictionary

Question

I am getting rows from a SQLite DB and trying to insert them into a dictionary. Except I keep getting errors! I get the error "Implicit conversion of an Objective-C pointer to 'const id *' is disallowed with ARC" Which I know means that I cant use a pointer when I am adding objects to my dictionary. So how do I go about fixing it so I can add those arrays to a dictionary?

    NSArray *keyArray = [[NSMutableArray alloc] init ];
    NSArray *valueArray = [[NSMutableArray alloc ] init ];
    NSDictionary* dic;
    NSInteger dataCount = sqlite3_data_count(statement);
    while (sqlite3_step(statement) == SQLITE_ROW) {
        @try {
            for (int i = 0; i < dataCount; i ++)
            {
                NSString* key = [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, i)];  
                NSString *value = [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, i)];

                if ([value length] == 0)
                {
                    value = @"";
                }

                keyArray = [keyArray arrayByAddingObject:key];
                valueArray = [valueArray arrayByAddingObject:value];

            }

        }
        @catch (NSException *ex)
        {
            NSLog(@"%@,%@", [ex name], [ex reason]);
        }

        dic= [NSDictionary dictionaryWithObjects:valueArray forKeys:keyArray count:[keyArray count]];

Why not use NSMutableArrays? And where exactly is your error? — ohr
– ohr, Commented Jul 30, 2012 at 18:00
A 0 length string is already @"" and there is no need to check the value. If you are checking for NULL then you need to check the value of sqlite3_column_text because stringWithUTF8String: will crash on NULL values. — Joe
– Joe, Commented Jul 30, 2012 at 18:06

Sergey Kalinichenko · Accepted Answer · 2012-07-30 18:11:22Z

5

The dictionaryWithObjects:forKeys:count: takes C-style arrays, not NSArray objects. The dictionaryWithObjects:forKeys: may do the trick, but you may be better off constructing a mutable dictionary as you go, bypassing NSArrays entirely.

NSDictionary* dic;
NSMutableDictionary *tmp = [NSMutableDictionary dictionary];

for (int i = 0; i < dataCount; i ++)
{
    NSString* key = [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, i)];  
    NSString *value = [NSString stringWithUTF8String:(char *)sqlite3_column_text(statement, i)];
    [tmp setObject:value forKey:key];
}
dict = tmp;

edited Jul 30, 2012 at 18:11

answered Jul 30, 2012 at 18:00

Sergey Kalinichenko

729k85 gold badges1.2k silver badges1.6k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ohr Over a year ago

dictionaryWithObjects:<#(NSArray *)#> forKeys:<#(NSArray *)#> takes NSArrays, would that help?

Sergey Kalinichenko Over a year ago

@OscarHernandez Thank you very much for bringing this up, I updated the answer. Thanks!

Joe Over a year ago

Since your answer is correct lets nitpick at it! Remove the [value length] check as it is unnecessary. See my comment above.

Sergey Kalinichenko Over a year ago

@Joe You're right, the value is not nil there, because a DB null would have crashed the line above it! Thanks!

Amol Badgujar · Accepted Answer · 2017-06-22 13:42:54Z

0

[dicBodyPost setValue:arrContactAddress forKey:@"contactAddress"];

answered Jun 22, 2017 at 13:42

Amol Badgujar

11

Collectives™ on Stack Overflow

Adding objects from array to dictionary

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related