Update database with javascript

Question

Because of the layout I can't use another <form> tag so I am trying to use javascript to update the database.

Since the code is just changing the URL with window.location.href it's not reloading the page to run the if statement.

Here is my code:

$check_view = $member->getUsersView($user_id);
if((isset($_GET['view-all'])) && $check_view != $_GET['view-all'])
{
    $view_all = $_GET['view-all'];
    $database->query('UPDATE users SET view_all = :viewall WHERE id = :userid', array(':viewall' => $view_all, ':userid' => $user_id));
}

<div onclick="javascript:window.location.href = \'page.php?action=list&'.(isset($_GET['view-all']) && $_GET['view-all']=="No" && $check_view=="No" ? 'view-all=Yes' : 'view-all=No').'\';">'.(isset($_GET['view-all']) && $_GET['view-all']=="No" && $check_view=="No" ? 'Show All' : 'Hide').'</div>

Anyone able to give me a hand with this?

EDIT: Thanks to the help of Matt I was able to get it working:

if(isset($_GET['view-all']))
{
    $check_view = $member->getUsersView($user_id);

    if($check_view != $_GET['view-all'])
    {
        $view_all = $_GET['view-all'];

        $database->query('UPDATE users SET view_all = :viewall WHERE id = :userid', array(':viewall' => $view_all, ':userid' => $user_id));
    }
}

$users_view = $member->getUsersView($user_id);

$view_all = "No";
$hide_show = "Hide";
if((isset($_GET['view-all']) && ($_GET['view-all']=="No")) || ($users_view=="No"))
{
    $view_all = "Yes";
    $hide_show = "Show All";
}

$data = '<a href="page.php?action=list&view-all='.$view_all.'">'.$hide_show.'</a>';

Why use a <div> + onclick instead of just a regular <a>? — j08691
– j08691, Commented Jul 31, 2012 at 15:50
You need to show the client-side output for your DIV, not your server-side PHP code. — Diodeus - James MacFarlane
– Diodeus - James MacFarlane, Commented Jul 31, 2012 at 15:52
For the love of GOD please define your onclick function in a <script> block and then call the function from there! — Matt
– Matt, Commented Jul 31, 2012 at 16:04

Matt · Accepted Answer · 2012-07-31 16:10:11Z

1

<a href="page.php?action=list&view-all=<?=(isset($_GET['view-all']) && $_GET['view-all']=="No" && $check_view=="No" ? "Yes" : "No"?>">
<?=isset($_GET['view-all']) && $_GET['view-all']=="No" && $check_view=="No" ? 'Show All' : 'Hide'?>
</a>

The above code will work but is UGLY AS SIN. Try cleaning it up:

<?php
$view_all = "No";
$hide_show = "Hide";
if (isset($_GET['view-all']) && $_GET['view-all']=="No" && $check_view=="No") {
    $view_all = "Yes";
    $hide_show = "Show All";
}
?>

<a href="page.php?action=list&view-all=<?= $view_all ?>"><?= $hide_show ?></a>

answered Jul 31, 2012 at 16:10

Matt

7,0504 gold badges31 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Draven Over a year ago

Any idea why "Show All" displays again after I click it? I have to click it a second time to get "Hide" to display. The "Hide" works fine, if I click it "Show All" displays.

Matt Over a year ago

@Draven not really, I just reorganized your code so it would be cleaner; I didn't check it for logical accuracy (sorry).

Draven Over a year ago

No problem. I just realized why. I am defining $check_view before it's updating the database with the new value.

Collectives™ on Stack Overflow

Update database with javascript

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related