Object Oriented JavaScript shared method variables

Question

Why doesn't this work?

function thing() {

    var bigvar;

    function method1() {
        bigvar = 1;
    }

    function method2() {
        alert(bigvar);
    }

    this.method1 = method1;
}

var a = new thing();
a.method1();
a.method2();

I want method2 to work, but it doesn't .. is there a way to make this work?

epascarello · Accepted Answer · 2012-08-07 16:41:39Z

3

You did not make method2 public like method1 is.

this.method1 = method1;
this.method2 = method2;  //<-- missing this

answered Aug 7, 2012 at 16:41

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

shabunc Over a year ago

to be strict, method1 is not made public, it is just declared as an assignment to local (or global, depends on implementation) function which haphazardly have "the same" name.

Polyov · Accepted Answer · 2012-08-07 16:43:00Z

0

Why do you have this.method1 = method1 but not this.method2 = method2? Try that.

answered Aug 7, 2012 at 16:43

Polyov

2,3293 gold badges26 silver badges36 bronze badges

Comments

Mark Pieszak - Trilon.io · Accepted Answer · 2012-08-07 16:51:05Z

0

Why not do this?

function thing() {

    var bigvar;

    this.method1 = function () {
        bigvar = 1;
    }

    this.method2 = function () {
        alert(bigvar);
    }

}

var a = new thing();
a.method1();
a.method2();

answered Aug 7, 2012 at 16:51

Mark Pieszak - Trilon.io

68.3k15 gold badges84 silver badges96 bronze badges

Collectives™ on Stack Overflow

Object Oriented JavaScript shared method variables

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related