Regex syntax issue [duplicate]

Question

Possible Duplicate:
Finetune Regex to skip tags

Currently my function looks like this. It converts plain text URLs into HTML links.

function UrlsToLinks($text){
    return preg_replace('@(https?://([-\w\.]+)+(:\d+)?(/([\w/_\.-]*(\?\S+)?)?)?)@', '<a href="$1" target="_blank">$1</a>', $text);
}

But there are some problems. What I'm trying to do is skip existing links, the src attribute in <img> tags, etc.. Can't figure out what I need to modify in this function.

Your desired functionality is painfully difficult, if not impossible, to achieve using regular expressions, much less a single regular expression. You really should be using an HTML parser, looking for links only within the text content of HTML nodes. — nickb
– nickb, Commented Aug 14, 2012 at 19:26
What you need to do is use an HTML parser to extract the text nodes and only run them through the above function. Trying to modify it so that it will ignore bits and pieces of HTML will bring down the wrath of Tony the Pony and we will all burn in the firey depths. Either that or your application will be insecure and unreliable, one of the two. — DaveRandom
– DaveRandom, Commented Aug 14, 2012 at 19:28
@epic_syntax: see the answer here: stackoverflow.com/q/11958415/1596455 — DesertEagle
– DesertEagle, Commented Aug 15, 2012 at 15:42

Tchoupi · Accepted Answer · 2012-08-14 20:04:28Z

1

This would work, assuming that the URLs we want to replace are not already inside a tag.

function UrlsToLinks($text){
    $matches = array();
    $strippedText = strip_tags($text);

    preg_match_all('@(https?://([-\w\.]+)+(:\d+)?(/([\w/_\.-]*(\?\S+)?)?)?)@', $strippedText, $matches);

    foreach ($matches[0] as $match) {       
        if (filter_var($match, FILTER_VALIDATE_URL)) {
            $text = str_replace($match, '<a href="'.$match.'" target="_blank">'.$match.'</a>', $text);
        }
    }
    return $text;
}

answered Aug 14, 2012 at 20:04

Tchoupi

14.7k5 gold badges39 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Regex syntax issue [duplicate]

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related