Javascript Adding variable to code

Question

This might be a really simple issue but I cannot spot the problem.

I have this code:

output += '<li><a href="#"><img src="'+value.thumbnail_url+'" /><h3>'+value.title+'</h3>'+value.body+'</a></li>';

I need to add this code after the href="#"

and replace the url string with this: value.media_url

I've come up with:

output += '<li><a href="#" onclick="window.plugins.childBrowser.showWebPage('+value.media_url+');"><img src="'+value.thumbnail_url+'" /><h3>'+value.title+'</h3>'+value.body+'</a></li>';

but there seems to be a syntax issue with the above as the link is not working.

The broken code is somewhere here: onclick="window.plugins.childBrowser.showWebPage('+value.media_url+');" as the rest works fine.

I could go even further ... here:

('+value.media_url+')

Can anyone see the problem?

Niet the Dark Absol · Accepted Answer · 2012-08-24 21:36:05Z

2

The resulting string is:

window.plugins.childBrowser.showWebPage(my/url/to/file.png)

As you can see, it's missing quotes around the string. Since it's in an attribute, you need this:

... onclick="window.plu.....WebPage(&quot;'+value.media_url+'&quot;)" ...

answered Aug 24, 2012 at 21:36

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Satch3000 Over a year ago

Tried it but I get the actual " as a string

Niet the Dark Absol Over a year ago

If you're looking at the HTML source, it's supposed to be like that. The browser will interpret it as quotes and the script should work fine.

Rab Khan · Accepted Answer · 2012-08-24 21:43:45Z

1

replacing onclick="window.plugins.childBrowser.showWebPage('+value.media_url+');" with onclick="window.plugins.childBrowser.showWebPage('"+value.media_url+"');" will fix it

answered Aug 24, 2012 at 21:43

Rab Khan

35.7k4 gold badges52 silver badges66 bronze badges

2 Comments

Satch3000 Over a year ago

Very strange...I replaced it with this: onclick="window.plugins.childBrowser.showWebPage('"+value.media_url+"');" ... and the page show a ); in the top corner for some reason

Niet the Dark Absol Over a year ago

It's a sadface at this answer's level of fail.

Collectives™ on Stack Overflow

Javascript Adding variable to code

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related