Echoing multiple rows of a database query with php

Question

I am trying to make an accordion (twitter bootstrap) displaying all of someone's friends, I end up just creating a infinate loop, basically all I am trying to do is echoing out a php string for each line in the results.

can anyone spot what I am doing stupid (other than not using mysqli)?

    while ( $rowresult = mysql_fetch_assoc(mysql_query("SELECT * FROM friends WHERE id='".$user["ID"]."' ")) ) {
        $auto = "0px";
        echo '<div class="accordion-group"><div class="accordion-heading"><div class="accordion-heading">';
        echo '<a class="accordion-toggle" data-toggle="collapse" data-parent="#accordion2" href="#collapse'. $counter . '">';       
        echo $rowresult['firstname'];
        echo ' ';
        echo $rowresult['lastname'];
        echo ', ';
        echo $rowresult['headline'];
        echo '</a></div> <div id="collapse'. $counter .'" class="accordion-body ';
        if ($counter == 0){
        echo 'in ';
        $auto = "auto";
        }
        echo 'collapse" style="height: '. $auto .'; "><div class="accordion-inner">';
        echo '<img src="'.$rowresult["pictureUrl"].'">';        
        echo '</div></div></div></div>';    
        $counter++;
    }

mysql_ functions have begun to be deprecated. Read this for more information. — Kermit
– Kermit, Commented Sep 4, 2012 at 1:02

Jocelyn · Accepted Answer · 2012-09-04 01:01:15Z

2

It doesn't work because you are executing the same query again and again.
Do that instead:

$res = mysql_query("SELECT * FROM friends WHERE id='".$user["ID"]."'");
while ( $rowresult = mysql_fetch_assoc($res) ) {
....
}

Also, I suggest you use MySQLi or PDO.

answered Sep 4, 2012 at 1:01

Jocelyn

11.4k11 gold badges47 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rob · Accepted Answer · 2012-09-04 00:58:32Z

1

You are repeating your query on every iteration. Move the mysql_query() out of the loop to a variable.

$q = mysql_query("SELECT * FROM friends WHERE id='".$user["ID"]."' ");
while ($rowresult = mysql_fetch_assoc($q)) {
    // ...
}

answered Sep 4, 2012 at 0:58

Rob

12.9k4 gold badges44 silver badges57 bronze badges

Comments

jtheman · Accepted Answer · 2012-09-04 00:59:39Z

0

Put the query before the while loop. IE

 $q=mysql_query("SELECT * FROM friends WHERE id='".$user["ID"]."' ");
 while ( $rowresult = mysql_fetch_array($q)) {

...

But then of course use PDO... :)

answered Sep 4, 2012 at 0:59

jtheman

7,5013 gold badges32 silver badges40 bronze badges

Collectives™ on Stack Overflow

Echoing multiple rows of a database query with php

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related