django - url patterns and if-else view

Question

I am trying to construct (somewhat RESTFul) URL's in django 1.4 that will allow filtering by book chapter, and then also book chapter and section. However, as of right now, only the specific chapter and section URL's return information. When I just input a chapter, the page displays without any content.

My urlpatterns in settings.py:

url(r'^(?i)book/(?P<chapter>[\w\.-]+)/?(?P<section>[\w\.-]+)/?$', 'book.views.chaptersection'),

My views.py:

from book.models import contents as C
def chaptersection(request, chapter, section):

if chapter and section:

    chapter = chapter.replace('-', ' ')
    section = section.replace('-', ' ')

    info = C.objects.filter(chapter__iexact=chapter, section__iexact=section).order_by('symb')
    context = {'info':info}
    return render_to_response('chaptersection.html', context, context_instance=RequestContext(request))

elif chapter:

    chapter = chapter.replace('-', ' ')

    info = C.objects.filter(chapter__iexact=chapter).order_by('symb')
    context = {'info':info}
    return render_to_response('chaptersection.html', context, context_instance=RequestContext(request))

else:
    info = C.objects.all().order_by('symb')
    context = {'info':info}
    return render_to_response('chaptersection.html', context, context_instance=RequestContext(request))

Again... the URL at "book/1/1" for chapter 1 section 1 works fine, but not "book/1", which should technically show all of chapter 1. I am not getting an error, but at the same time, nothing is being displayed on the screen.

Alasdair · Accepted Answer · 2012-09-13 23:55:17Z

2

You have made the trailing slashes optional, but your regex still requires at least one character for the section argument.

Try changing

(?P<section>[\w\.-]+)

to

(?P<section>[\w\.-]*)

Personally, I find it clearer to declare two URL patterns instead of one with an optional parameter.

url(r'^(?i)book/(?P<chapter>[\w\.-]+)/$', 'book.views.chaptersection'),
url(r'^(?i)book/(?P<chapter>[\w\.-]+)/(?P<section>[\w\.-]+)/$', 'book.views.chaptersection'),

This requires a small adjustment to your chaptersection view to make section an optional argument:

def chaptersection(request, chapter, section=None):

edited Sep 13, 2012 at 23:55

answered Sep 13, 2012 at 22:55

Alasdair

310k59 gold badges605 silver badges534 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

django - url patterns and if-else view

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related