Refactor JQuery setting checkbox attribute

Question

Can this code be written in a one-line format?

if ($('#sIsTopNav').text().trim() === 'True') {
    $('#chkIsTopNav').attr('checked','checked');
}else {
    $('#chkIsTopNav').removeAttr('checked');
}

TIA ..

Why would you want to do this? Don't fix what's not broken, also one liners don't always read well. — CR41G14
– CR41G14, Commented Dec 4, 2012 at 15:58

Adil · Accepted Answer · 2012-12-04 15:58:18Z

4

Try using conditional (ternary) operator,

$('#sIsTopNav').text().trim() === 'True' ? $('#chkIsTopNav').attr('checked','checked') :  $('#chkIsTopNav').removeAttr('checked');

answered Dec 4, 2012 at 15:58

Adil

148k25 gold badges217 silver badges207 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

techfoobar · Accepted Answer · 2012-12-04 15:59:09Z

1

You can do:

$('#chkIsTopNav').prop('checked', $('#sIsTopNav').text().trim() === 'True')

Note:

Removing the checked attribute has the same effect as setting it to false.
Using .prop() is the current recommended way for setting properties like checked, disabled etc.

answered Dec 4, 2012 at 15:59

techfoobar

66.8k14 gold badges117 silver badges138 bronze badges

Collectives™ on Stack Overflow

Refactor JQuery setting checkbox attribute

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related