Unable to pass date from c# to javascript function

Question

I'm dynamically building html table from c# code. Here is a portion of my code:

listHTML.Append("<td onClick='GoToHourlyReport("
    + Convert.ToDateTime(dr["IntervalStartTime"]).ToString("yyyy-MM-dd")
    + ","
    + deptId
    + ");' align='center' valign='middle' class='graph_red_grid_text'>"
    + Convert.ToDateTime(dr["IntervalStartTime"]).ToString("yyyy-MM-dd hh:mm:ss")
    + "</td>"
);

On onclick of the td I'm trying to pass a date to a JavaScript function.

onClick='GoToHourlyReport("
    + Convert.ToDateTime(dr["IntervalStartTime"]).ToString("yyyy-MM-dd")
    + ","
    + deptId
    + ");'

But when I pass a date like 2012-10-01, I get a value 1999 inside JavaScript function all the time. Can any one throw some light about what I'm doing wrong?

Here is the js function

    function GoToHourlyReport(date, deptId) {
    window.location.href = "CallAverageHourlyReport_BW.aspx?Date=" + date + "&Queue=" + deptId;
}

Sounds more like the javascript function (which isn't shown) is manipulating the date. — csharpnumpty
– csharpnumpty, Commented Dec 6, 2012 at 13:34

epascarello · Accepted Answer · 2012-12-06 13:33:54Z

4

View the page source, you will see your problem. You are missing quotes in the generated code.

In short you are doing

alert(2012-10-01);

not

alert("2012-10-01");

Add an escaped "

listHTML.Append("<td onClick='GoToHourlyReport(\"" + Convert.ToDateTime(dr["IntervalStartTime"]).ToString("yyyy-MM-dd") + "\",\"" + deptId + "\");'...

answered Dec 6, 2012 at 13:33

epascarello

208k20 gold badges206 silver badges246 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

iJade Over a year ago

well how to add " before date. I tried by adding a ' but it was rendering ? mark

epascarello Over a year ago

Add an escaped " to surround the strings. Or use a string builder!

Mike Perrenoud Over a year ago

@jade, please mark this as the answer, both for the contributor and the community. Thanks!

jbabey · Accepted Answer · 2012-12-06 13:43:06Z

1

You need to pass the date as a string, otherwise it gets interpreted as a number (2,010 minus 10 minus 1 = 1,999):

listHTML.Append("<td onClick=\"GoToHourlyReport('"
    + Convert.ToDateTime(dr["IntervalStartTime"]).ToString("yyyy-MM-dd")
    + "',"
    + deptId
    + ");\" align='center' valign='middle' class='graph_red_grid_text'>"
    + Convert.ToDateTime(dr["IntervalStartTime"]).ToString("yyyy-MM-dd hh:mm:ss")
    + "</td>"
);

This should generate:

<td onclick="GoToHourlyReport('2010-10-01', 1)" ...>

answered Dec 6, 2012 at 13:43

jbabey

46.7k12 gold badges73 silver badges94 bronze badges

Collectives™ on Stack Overflow

Unable to pass date from c# to javascript function

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related