PHP if statement disregarding variable check

Question

My if statement keeps looking over one of my variables and looks at the or statements and returns true. I hate describing coding before showing it...

if($relLoc[1] <= "32" AND $map['locationpadding'] == "0px 0px -32px 0px" OR $map['locationpadding'] == "0px 0px -32px -32px" OR $map['locationpadding'] == "0px -32px -32px 0px")
{
    die();
}

So if I am at $map['locationpadding'] == "0px 0px -32px -32px" and the $relLoc[1] == "380" the die(); still executes.

But if I am at 0px 0px -32px 0px It wont execute till I am at the 32 location.

I originally tried that, researched it on w3 and tried that route. Still same thing. The "OR" should be fine. — Ajezior
– Ajezior, Commented Dec 14, 2012 at 19:09
Never mind, you guys win. Thanks! But why would this one fail. if($relLoc[0] <= "32" && $map['locationpadding'] == "0px 0px -32px -32px" || $map['locationpadding'] == "0px 0px 0px -32px" || $map['locationpadding'] == "-32px 0px 0px -32px"){ die(); } — Ajezior
– Ajezior, Commented Dec 14, 2012 at 19:11

Woot4Moo · Accepted Answer · 2012-12-14 19:09:33Z

2

You have not correctly grouped the logic statements. I do not know PHP so the syntax may be off but you essentially want this:

if($relLoc[1] <= "32"  AND **(** $map['locationpadding'] == "0px 0px -32px 0px" OR $map['locationpadding'] == "0px 0px -32px -32px" OR $map['locationpadding'] == "0px -32px -32px 0px"**)** ){
            die();
        }

Notice the additional parenthesis to denoted the correct group of boolean statements. What you have done in your original post is this:

if relLoc == 32 AND  $map['locationpadding'] == "0px 0px -32px 0px

  +  
OR $map['locationpadding'] == "0px 0px -32px -32px"   
  + 
OR $map['locationpadding'] == "0px -32px -32px 0px

So in the sample you provided it would be this:

$map['locationpadding'] == "0px 0px -32px -32px" and the $relLoc[1] == "380"

which is:

   False + True + False = True

answered Dec 14, 2012 at 19:09

Woot4Moo

24.4k19 gold badges103 silver badges156 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ajezior Over a year ago

Awesome! Thanks for the help. All for parenthesis! Works great now!

Woot4Moo Over a year ago

@Ajezior great, common courtesy is to upvote / accept if this is the correct solution.

MrCode · Accepted Answer · 2012-12-14 19:09:41Z

0

Looks like you want:

if($relLoc[1] <= "32" AND ($map['locationpadding'] == "0px 0px -32px 0px" OR $map['locationpadding'] == "0px 0px -32px -32px" OR $map['locationpadding'] == "0px -32px -32px 0px")){
//                        ^ added                                                                                                                                                ^ added

Use parenthesis to separate sub conditions, otherwise your first condition becomes less relevant because after that you have OR x OR x OR x, so only one of the ORs has to evauluate to true for the whole condition to evaluate to true.

answered Dec 14, 2012 at 19:09

MrCode

64.6k10 gold badges95 silver badges114 bronze badges

Collectives™ on Stack Overflow

PHP if statement disregarding variable check

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related