arning json and its nullpointer exception while getting JSONarray

Question

I am learning JSON and its parsing in android using same code/example
http://www.androidhive.info/2012/01/android-json-parsing-tutorial/

but while implementing and running its give null pointer exception

while getting JSON i.e on contacts = json.getJSONArray(TAG_CONTACTS);

  JSONArray contacts = null;
 private static String url = "http://api.androidhive.info/contacts/";


 public void initParsing()
 {
    ListView listView = (ListView) findViewById(R.id.listView_song);
     ArrayList<HashMap<String, String>> contactList = new ArrayList<HashMap<String, String>>();
     JSONParser jParser = new JSONParser();
     JSONObject json = jParser.getJSONFromUrl(url);
     try {
            // Getting Array of Contacts
            System.out.println("---getJSON");
            contacts = json.getJSONArray(TAG_CONTACTS);

            // looping through All Contacts
            for(int i = 0; i < contacts.length(); i++){
                JSONObject c = contacts.getJSONObject(i);
                 System.out.println("---times");
                // Storing each json item in variable
                String id = c.getString(TAG_ID);
                String name = c.getString(TAG_NAME);
                String email = c.getString(TAG_EMAIL);
                String address = c.getString(TAG_ADDRESS);
                String gender = c.getString(TAG_GENDER);

                // Phone number is agin JSON Object
                JSONObject phone = c.getJSONObject(TAG_PHONE);
                String mobile = phone.getString(TAG_PHONE_MOBILE);
                String home = phone.getString(TAG_PHONE_HOME);
                String office = phone.getString(TAG_PHONE_OFFICE);

                // creating new HashMap
                HashMap<String, String> map = new HashMap<String, String>();

                // adding each child node to HashMap key => value
                map.put(TAG_ID, id);
                map.put(TAG_NAME, name);
                map.put(TAG_EMAIL, email);
                map.put(TAG_PHONE_MOBILE, mobile);

                // adding HashList to ArrayList
                contactList.add(map);
            }
        } catch (JSONException e) {
            e.printStackTrace();
        }

//       ListAdapter adapter = new SimpleAdapter(this, contactList,
//                  R.layout.list_item,
//                  new String[] { TAG_NAME, TAG_EMAIL, TAG_PHONE_MOBILE }, new int[] {
//                          R.id.name, R.id.email, R.id.mobile });

       // setListAdapter(adapter);
    //  listView.setAdapter(new CustomArrayAdapter(this, TAG_NAME)); // setting the adapter


 }

show us the logcat output and where exactly the app is crashing — hardartcore
– hardartcore, Commented Jan 2, 2013 at 13:43
did you seriously commented on your own question a minute after asking it ? — njzk2
– njzk2, Commented Jan 2, 2013 at 14:04

Manmeet Singh Batra · Accepted Answer · 2013-01-02 13:42:13Z

1

public void initParsing()
 {
    ListView listView = (ListView) findViewById(R.id.listView_song);
     ArrayList<HashMap<String, String>> contactList = new ArrayList<HashMap<String, String>>();
     JSONParser jParser = new JSONParser();
     JSONObject json = jParser.getJSONFromUrl(url);
     try {
            // Getting Array of Contacts
            System.out.println("---getJSON");
           if(json != null && json.has("contacts")){
            contacts = json.getJSONArray("contacts");

            // looping through All Contacts
            for(int i = 0; i < contacts.length(); i++){
                JSONObject c = contacts.getJSONObject(i);
                 System.out.println("---times");
                // Storing each json item in variable
                String id = c.getString(TAG_ID);
                String name = c.getString(TAG_NAME);
                String email = c.getString(TAG_EMAIL);
                String address = c.getString(TAG_ADDRESS);
                String gender = c.getString(TAG_GENDER);

                // Phone number is agin JSON Object
                JSONObject phone = c.getJSONObject(TAG_PHONE);
                String mobile = phone.getString(TAG_PHONE_MOBILE);
                String home = phone.getString(TAG_PHONE_HOME);
                String office = phone.getString(TAG_PHONE_OFFICE);

                // creating new HashMap
                HashMap<String, String> map = new HashMap<String, String>();

                // adding each child node to HashMap key => value
                map.put(TAG_ID, id);
                map.put(TAG_NAME, name);
                map.put(TAG_EMAIL, email);
                map.put(TAG_PHONE_MOBILE, mobile);

                // adding HashList to ArrayList
                contactList.add(map);
            }
            }
        } catch (JSONException e) {
            e.printStackTrace();
        }

//       ListAdapter adapter = new SimpleAdapter(this, contactList,
//                  R.layout.list_item,
//                  new String[] { TAG_NAME, TAG_EMAIL, TAG_PHONE_MOBILE }, new int[] {
//                          R.id.name, R.id.email, R.id.mobile });

       // setListAdapter(adapter);
    //  listView.setAdapter(new CustomArrayAdapter(this, TAG_NAME)); // setting the adapter


 }

answered Jan 2, 2013 at 13:42

Manmeet Singh Batra

4672 silver badges5 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

AndDev21 Over a year ago

if i write else part of if(json != null && json.has("contacts")) it is going in that but looking at the json by hitting that link it has the contacts.... can anyone explain what is happening here

Manmeet Singh Batra Over a year ago

Could you tell me what is the use of else part, if you have contacts JSONARRAY only then there is need to parse the response, isn't it?

AndDev21 Over a year ago

Hey friend the problem is resolve many thanks to you and others

Nermeen · Accepted Answer · 2013-01-02 13:37:08Z

0

Make sure the json array name is right..try using

contacts = json.getJSONArray("contacts");

answered Jan 2, 2013 at 13:37

Nermeen

16k5 gold badges62 silver badges73 bronze badges

2 Comments

AndDev21 Over a year ago

by hitting the link from where i am getting JSON array, it has the same

AndDev21 Over a year ago

no change same issue, problem is somewhere else or i am missing something?

Ricky Khatri · Accepted Answer · 2013-01-02 13:40:19Z

0

You must use this:

contacts = json.optJSONArray("array name");

this will return an array if your response having an array otherwise it will return null.

answered Jan 2, 2013 at 13:40

Ricky Khatri

9602 gold badges16 silver badges43 bronze badges

5 Comments

AndDev21 Over a year ago

thanks for your suggestion brother but issue remains the same

Ricky Khatri Over a year ago

Are you sure you are getting an array values.

Ricky Khatri Over a year ago

Could you post your JSON response.

njzk2 Over a year ago

you must not. both methods exist, in some case test for null is good, in some other, you expect an exception because your app cannot run without data.

AndDev21 Over a year ago

thanks a lot friend the issue is resolved now.... i did little research and effort by own and solution came.. thanks a lot

Collectives™ on Stack Overflow

arning json and its nullpointer exception while getting JSONarray

3 Answers 3

3 Comments

2 Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related