While loop in while loop

Question

THANKS FOR THE ANSWERS, I am really glad.. I edited the code and I want to ask, if I edited it well? :-)

  $result = $sql->query("SELECT * FROM `topic` ;");
                    while($row = $result->fetch_object())
                    {
                    $id=$row->id;
                    $photo=$row->photo;
                    $title=$row->title;
                    $shortinfo=$row->shortinfo;
                    echo"<div id='article'>
                        <a href='reporty.php?page=$id'><div id='article_img'><img src='$photo'/></div></a>
                        <div id='article_text'>
                        <h2>$title</h2>
                        <p>$shortinfo</p>
                        </div>
                        </div>";

Mihai Matei · Accepted Answer · 2013-01-10 11:46:49Z

1

You should set the second query as $result1 because the new one is replacing the first one.. That's why you have always just one result

$result = $sql->query("SELECT * FROM `topic` ;");
while($row = $result->fetch_object())
{
   $id=$row->id;                     
   echo '<div id="article">
            <a href="';
   echo '.php"><div id="article_img"><img src="';
   $result1 = $sql->query("SELECT `photo` FROM `topic` WHERE id='$id' ;");
   while ($row1 = $result->fetch_array()) {
       echo $row1['photo'];
   }
}

answered Jan 10, 2013 at 11:46

Mihai Matei

24.3k5 gold badges34 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Manoj Purohit · Accepted Answer · 2013-01-10 11:47:40Z

1

$result and $row same variable name is used in both loops.

answered Jan 10, 2013 at 11:47

Manoj Purohit

3,4631 gold badge17 silver badges17 bronze badges

Comments

pdu · Accepted Answer · 2013-01-10 11:50:48Z

0

I'd suggest to use readable and self-explanatory variable names, like $photo_result and $title_result. This then would also solve your problem since you use the same variable names in your loops.

For the sake of performance and simplicity, why don't you JOIN your tables? Then you'd only have one query with one loop.

answered Jan 10, 2013 at 11:50

pdu

10.5k4 gold badges61 silver badges96 bronze badges

Comments

Sahal · Accepted Answer · 2013-01-10 11:52:12Z

0

Give proper variable name always. Your $result and $row is holding all most all variable here.

Same memory location will be updated always. So it loses the old values (We learned this in 1st year degree/ PUC first year)

Do it like this,

for example when you are fetching from topic table and you select photo,

use variables like $topicResultForPhto and$topicPhotoRow`. Do this for all.

And one more error,

You already calls like SELECT * and you have all the fields from table. Why should again a call from photo and other fields like select photo from topics where ?

answered Jan 10, 2013 at 11:52

Sahal

4,15616 gold badges45 silver badges72 bronze badges

Collectives™ on Stack Overflow

While loop in while loop

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related