PHP generated content inside Javascript breaking script

Question

I have a website with some Javascript rotating content with a fade. The script works fine until I add a PHP while loop inside it, then it fails. I'm using the PHP to pull content from wordpress posts.

here is the isolated code (http://jsfiddle.net/dzz8M/2/). You'll notice the script works as desired if you remove the PHP and you can see here (http://www.smartcallclaims.com/indexx.php/) that the php is outputting fine.

When you check the source of that link and look for the JavaScript from the JSfiddle you'll see the PHP has generated it's content inside the script. (I know it adds a <p> tag, this is not the issue)

Can some please tell me why the PHP breaks the javascript?

As a note, Java and Javascript are two separate things. Also, a jsfiddle, and your site do not help in this matter. Please post the php you are using to generate your other code." — Daedalus
– Daedalus, Commented Feb 2, 2013 at 9:06
All things Daedalus says, and, if you set up a fiddle: set it up properly... — Elias Van Ootegem
– Elias Van Ootegem, Commented Feb 2, 2013 at 9:38
I've left the PHP in the JSfiddle page for reference.... The Jsfiddle page was created for the purpose of allowing the community to both see and test the PHP/Javascript for themselves rather than coming back with pointless replies. — Sue.My.Chin
– Sue.My.Chin, Commented Feb 2, 2013 at 9:39

Sirko · Accepted Answer · 2013-02-02 09:14:37Z

1

Your problem is the one unescaped linebreak in the quotes:

"\&nbsp;&nbsp;&nbsp;&nbsp;<p>this is a good web test</p>
<div id='quoteauthor'>Ben Harrison</div>",

This is not valid JavaScript. You have to escape it somehow, for example like by using str_replace() in the PHP functions, that create those strings.

str_replace("\n","&nbsp;",$string)

answered Feb 2, 2013 at 9:14

Sirko

74.3k19 gold badges157 silver badges194 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Sue.My.Chin Over a year ago

Do you mean after the </p>? I think I know what you mean.

Sue.My.Chin Over a year ago

You're dead right, the PHP is generating the line break server-side, it's not in my code. Have you any suggestions as to how the line break could stay in there without it messing up the Javascript? The str_replace, would that be able to go on the line above the PHP in question? Thanks for helping, unlike the posters above who clearly haven't read the question correctly.

Sirko Over a year ago

@Sue.My.Chin Do you have access to the function the_excerpt()? The str_replace() should go in there.

Sue.My.Chin Over a year ago

the_excerpt() is a custom field within the post type. All you can input is text. I can however create a separate field to use instead of the excerpt. I'll try this now and report back.

Sue.My.Chin Over a year ago

I created a separate, plain text-field and it didn't create the line break. Everything renders perfectly. :) I could kiss you Sirko. Thank you very much for the help!

Collectives™ on Stack Overflow

PHP generated content inside Javascript breaking script

1 Answer 1

5 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related