0

Hi i am totally confused with a date logic in my mysql query for a cron job to be run everyday at 12:00 AM

I am working on a auto listing website where the car listings are having a expiry date in mysql datetime format.

All the expired listings will be deleted from the website after 7 days from the datetime of the expiry

When the cron job will run it has do following things

Task 1 - Send an email alert to the users telling them that their listing has expired.

So I need to select all those listings which have expired since last time the cron job has been run and not include listings before that in order to send the expiry alert email only once per listing.

I tried following sql query for this task (Again confused with this as well)

SELECT car_id FROM cars WHERE expiry_date > DATE_SUB(NOW(), INTERVAL 1 DAY) AND expiry_date < NOW()

Task 2 - Will send an email alert to users telling them that listing is going to be permanently deleted after 24 hours.

So I need to select all those listings which are going to be deleted in more than 24 hours / 6 days have passed since they were expired and i need to make sure that they get minimum 24 hours time to renew them. Also i need to select / build the sql query in such a way that only those listings get selected which are going to expiry in 1 days and not other in order to avoid multiple email alerts instead of one time email alert

I tried following sql query for this task (I am totally confused with this query)

SELECT car_id FROM cars WHERE expiry_date > DATE_SUB(NOW(), INTERVAL 7 DAY) AND expiry_date < DATE_SUB(NOW(), INTERVAL 1 DAY)

Task 3 - Delete all the listings which were expired more than 7 days ago

I tried following sql query for this task

SELECT car_id FROM cars WHERE expiry_date < DATE_SUB(NOW(), INTERVAL 7 DAY)

Please help me in perfecting all the 3 queries so that the cron does it job exactly as i want. Also please let me where it has to >= (greater than or equal to) or <= (less than or equal to)

Here is the sqlfiddle table structure and couple of records (though they are not expired yet)

http://sqlfiddle.com/#!2/cfcdf

I will really appreciate the help.

4
  • Give us a sample of the table data or, for preferance, a SQLFiddle Commented Feb 4, 2013 at 4:59
  • @DaleM - I have added the phpmyadmin dump, being a newbie cant figure out how to save and share a sqlfiddle though still trying Commented Feb 4, 2013 at 5:22
  • @DaleM - I have added the sqlfiddle, please help me with it Commented Feb 4, 2013 at 5:32
  • @Asnexplore Event schedule would have been good too... to fire at 12noon or midnight.. Commented Feb 4, 2013 at 6:01

3 Answers 3

1

Is this what you are looking for? Please try to add another column to see the differnce between expiry_date and current date time for you to get a better idea of the dates you are dealing with. Please look into some dates functions in MYSQL.

SQLFIDDLE DEMO

-- 3rd query expiry dates older than 7 days from 
-- today

SELECT car_id, expiry_Date, 
DATE_sub(NOW(), INTERVAL 7 DAY)
FROM cars 
WHERE expiry_date <= 
DATE_sub(NOW(), INTERVAL 7 DAY)
;

-- same

SELECT car_id, expiry_Date, 
DATE_ADD(NOW(), INTERVAL -7 DAY)
FROM cars 
WHERE expiry_date <= 
DATE_ADD(NOW(), INTERVAL -7 DAY)
;


-- 2nd query going to expire in exactly 1 day

SELECT car_id, expiry_date, 
Now() + interval 1 day
FROM cars 
WHERE expiry_Date = Now() + interval 1 day
;

-- 1st query: expired 

SELECT car_id FROM cars 
WHERE expiry_date < Now()
;

-- 1st query: expired last 24 hours

SELECT car_id,DATEDIFF(expiry_date, Now())
FROM cars 
WHERE expiry_Date < Now()
AND expiry_Date >= Now() - interval 1 day
;
Sign up to request clarification or add additional context in comments.

1 Comment

could cognos do this kind of query?
1

Check out these queries

select * from cars where datediff(EXPIRY_DATE,now())=-1;


select * from cars where 
datediff(DATE_ADD(EXPIRY_DATE, interval 24 hour),now())>=1 and
datediff(DATE_ADD(EXPIRY_DATE, interval 24 hour),now()) <=2;



select * from cars where datediff(expiry_date,now())<=-7;

ope they are working according to your need.

fiddle http://sqlfiddle.com/#!2/785ea/5

Comments

0

There is nothing significantly wrong with your queries, if you do not understand the functions that you have used then google them and read about them until you do.

There is a fundamental problem in your approach in that it relies on the cron job being run at exactly 24 hour intevals - to the milisecond - or there will be double ups and/or omissions.

You need another table to store details of when your batch program last ran; intitialise this with 1 row with a date a long time in the past so that we have a starting point.

You can get the most recent batch by SELECT MAX(date_ran) FROM BatchRecordTables. Store this in a local variable T0. Get the current time, store this in a local variable T1 (Do not use NOW() in multiple queries as they will be slightly differant times and you need them to be the same). I do not know the syntax for this is MySQL - you will have to look it up.

Your situations then become.

  1. Send email to people whose listings have expired since that last time the cron job was run i.e. SELECT car_id FROM cars WHERE Expiry_Date BETWEEN T0 AND T1. This will only select people whoose listings have expired between this batch and the previous one.
  2. For the second case, we need to know that these people have got the first email i.e. that their listing had expired before the last batch run so SELECT car_id FROM cars WHERE Expiry_Date BETWEEN DATE_SUB(T1, INTERVAL 6 DAY) AND T0. This will only select people whoose listings expired before the last batch (i.e. they got the exprired email) and more than 6 days ago.
  3. Same logi applies - we want to know they got the second email. SELECT car_id FROM cars WHERE Expiry_Date BETWEEN DATE_SUB(T1, INTERVAL 7 DAY) AND DATE_SUB(T0, INTERVAL 6 DAY)

May I also suggest that you do not permenantly delete the listings but either copy them to a DeletedListings table or Flag them with a Deleted column - each has its own pros and cons. In the information age, never throw data away - you never know when it might be valuable.

3 Comments

I have created a cron job table with field last_run_at that stores the datetime of last time the cron runs, but i need to how can I store the SELECT MAX(date_ran) FROM BatchRecordTables in temporary variable and use it in my queries. Can you plz help me with it?
@Asnexplore Not really, I use SQL Server and am unfamiliar with MySQL syntax - why don't you google it?
Never mind, I have found it at atcomm.com.au/Atcomm-Underground/MySQL/…

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.