Redirect is not working in php, using header

Question

I am wondering why this is not relocating me to the contact page?

    <?php session_start(); ?>


    <?php

    function setSessions($page){
        switch($page)
        {
            case "contact":
                $_SESSION['contact_name'] = $_GET['name'];
                $_SESSION['contact_address'] = $_GET['address'];
                $_SESSION['contact_phone'] = $_GET['phone'];
                header('Location:contact.php');
                exit;
                break;
            case "employment":
                break;
            case "position":
                break;
            default:
                break;
        }

    }




    $current_page = $_REQUEST['page'];
    setSessions($current_page);


    ?>

I am positive it is going in the contact case. thanks for the help

-edit: NVM, it works. Thanks!

you are outputting a string, before the header that should be causing an error. You have error checking\display off which is a bad way to develop code — user557846
– user557846, Commented Feb 5, 2013 at 3:15
-post edit, still error checking must be off, so how would know if you got an error? — user557846
– user557846, Commented Feb 5, 2013 at 3:18
That white space is still output. just combine that all into one php enclosure — Kai Qing
– Kai Qing, Commented Feb 5, 2013 at 3:18
in addition you should use the full URI in header location not a relative one — user557846
– user557846, Commented Feb 5, 2013 at 3:20

Supericy · Accepted Answer · 2013-02-05 03:16:33Z

2

You can't send any output before making a call to header().

You would have to remove:

<html>

and

echo "i got in here";

References:

http://php.net/manual/en/function.header.php

Remember that header() must be called before any actual output is sent, either by normal HTML tags, blank lines in a file, or from PHP.

answered Feb 5, 2013 at 3:16

Supericy

5,8911 gold badge23 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kai Qing · Accepted Answer · 2013-02-05 03:15:44Z

1

This is why:

 <html>

You can't call header() if you have output anything to the browser. Move the redirect code above this html tag and remove that echo and you should be ok.

answered Feb 5, 2013 at 3:15

Kai Qing

18.9k6 gold badges41 silver badges61 bronze badges

1 Comment

Kai Qing Over a year ago

such a bad habit to get into though. just following the normal conventions would be a better approach to php

amof · Accepted Answer · 2013-02-05 03:29:43Z

1

For future reference white html space before header being called will also stop this from working. (lines 2 & 3)

answered Feb 5, 2013 at 3:29

amof

4161 gold badge7 silver badges14 bronze badges

1 Comment

user557846 Over a year ago

4 answers and 3 comments saying the same thing, but feel free to add your answer 20 minutes latter anyway :-)

Matt Whitehead · Accepted Answer · 2013-02-05 03:16:32Z

0

You can't have ANY output what so ever before using header(). The echo statement in your switch statement is considered output and is the thing messing up your code.

answered Feb 5, 2013 at 3:16

Matt Whitehead

1,8213 gold badges20 silver badges34 bronze badges

Comments

Explosion Pills · Accepted Answer · 2013-02-05 03:16:47Z

0

Any emission sends headers in PHP, and once you've sent headers you can't send any more. Even whitespace will do this, but you have the string <html> being output. You can't do that.

The better solution is to not do it and save all emission until after you have built everything that you want to output.

The worse solution would be to use output buffering. At the start of your script but, ob_start(). Then, headers will work as normal.

answered Feb 5, 2013 at 3:16

Explosion Pills

192k56 gold badges341 silver badges417 bronze badges

2 Comments

AustinT Over a year ago

Okay, so i've taken out all the output, and now its just going to a blank page.

Explosion Pills Over a year ago

Are you sure it's not redirecting? Or do the pages you're redirecting to just not have any content?

Flexo - Save the data dump · Accepted Answer · 2013-07-13 11:16:26Z

0

The problem is that you are not getting the correct value for $current_page; you can echo that value and you will see it's empty. So what you need to do is you should take the current page value here using this function:

function getMyurl(){

  $url = (!empty($_SERVER['HTTPS'])) ? "https://".$_SERVER['SERVER_NAME'].$_SERVER['REQUEST_URI'] : "http://".$_SERVER['SERVER_NAME'].$_SERVER['REQUEST_URI'];

  echo $url;

}

now $current_page=getMyurl();

You should know that getMyurl will return a full url of your website or application so you should modify it in your cases where it's written contact you should replace that with case "yourwebsite/contact".

It should now work for you

edited Jul 13, 2013 at 11:16

Flexo - Save the data dump♦

89.1k22 gold badges205 silver badges286 bronze badges

answered Feb 5, 2013 at 3:35

sulayman

1372 silver badges8 bronze badges

Collectives™ on Stack Overflow

Redirect is not working in php, using header

6 Answers 6

Comments

1 Comment

1 Comment

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

1 Comment

1 Comment

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related