What is wrong with this code that uses the mysql extension to fetch data from a database in PHP?

Question

I want to fetch data from a mysql table using php. Please, can anyone tell me what is wrong with this code? What is the correct code to fetch data from a mysql database:

 <?php
    $dbhost = 'localhost';
    $dbuser = 'root';
    $dbpass = '';
    $connect=mysql_connect("localhost","root","");

    // connect to databsase 

    mysql_select_db("form1",);

        enter code here

    // query the database 

    $query = mysql_query("SELECT * FROM users WHERE name = 'Admin' ");

    // fetch the result / convert resulte in to array 

    while ($rows = mysql_fetch_array($query)):

       $rows = $rows['Name'];
       $address = $rows['Address'];
       $email = $rows['Email'];
       $subject = $rows['Subject'];
       $comment = $rows['Comment'];

       echo "$Name<br>$Address<br>$Email<br>$Subject<br>$Comment<br><br>";

       endwhile;

       ?>

You are using an obsolete database API and should use a modern replacement. — Quentin
– Quentin, Commented Feb 12, 2013 at 7:19
what reason to declare those above variables for when you use mysql_connect("localhost","root","");? And tell us the result you get from this code — Tepken Vannkorn
– Tepken Vannkorn, Commented Feb 12, 2013 at 7:21
Don't use the outdated MySQL library; use MySQLi or PDO - if you're just learning how to do this, learn to do it using the right library and with parameterised queries rather than a deprecated library — Mark Baker
– Mark Baker, Commented Feb 12, 2013 at 7:25

Code Prank · Accepted Answer · 2013-02-12 07:21:47Z

6

Variables in php are case sensitive. Please replace your while loop with following:

while ($rows = mysql_fetch_array($query)):

           $name = $rows['Name'];
           $address = $rows['Address'];
           $email = $rows['Email'];
           $subject = $rows['Subject'];
           $comment = $rows['Comment']

           echo "$name<br>$address<br>$email<br>$subject<br>$comment<br><br>";

           endwhile;

answered Feb 12, 2013 at 7:21

Code Prank

4,2706 gold badges34 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

afro360 · Accepted Answer · 2013-02-12 07:39:22Z

Try this

<?php
// 1. Enter Database details
$dbhost = 'localhost';
$dbuser = 'root';
$dbpass = 'password';
$dbname = 'database name';

// 2. Create a database connection
$connection = mysql_connect($dbhost,$dbuser,$dbpass);
if (!$connection) {
    die("Database connection failed: " . mysql_error());
}

// 3. Select a database to use 
$db_select = mysql_select_db($dbname,$connection);
if (!$db_select) {
    die("Database selection failed: " . mysql_error());
}

$query = mysql_query("SELECT * FROM users WHERE name = 'Admin' ");

while ($rows = mysql_fetch_array($query)) { 
   $name = $rows['Name'];
   $address = $rows['Address'];
   $email = $rows['Email'];
   $subject = $rows['Subject'];
   $comment = $rows['Comment']

   echo "$name<br>$address<br>$email<br>$subject<br>$comment<br><br>";      
} 

?>

Not tested!! *UPDATED!!

Mohamed Shahid · Accepted Answer · 2016-05-12 03:12:15Z

1

Change the "WHILE" to "while". Because php is case sensitive like c/c++.

answered May 12, 2016 at 3:12

Mohamed Shahid

4755 silver badges18 bronze badges

Comments

Marimuthu · Accepted Answer · 2013-02-12 07:26:12Z

0

Select a database with identifier mysql_select_db("form1",$connect);
Are you getting syntax error? If please put a ; next to $comment = $rows['Comment'].
Also the variables should be case sensitive here

answered Feb 12, 2013 at 7:26

Marimuthu

1

Comments

Rahul Nanwani · Accepted Answer · 2013-04-25 04:24:11Z

0

If this is the code you have, then you will get an error because, you are reassigning $row while in the loop, so you would never be able to iterate over the results. Replace

$rows = $rows['Name'];

with

$name = $rows['Name']'

So your code would look like

WHILE ($rows = mysql_fetch_array($query)):

   $name = $rows['Name'];
   $address = $rows['Address'];
   $email = $rows['Email'];
   $subject = $rows['Subject'];
   $comment = $rows['Comment'];

Also I am assuming that the column names in the table users are Name, Address, Email etc. and not name,address, email. Remember that every variable name/field nameh is case sensitive.

answered Apr 25, 2013 at 4:24

Rahul Nanwani

1,2871 gold badge11 silver badges22 bronze badges

Comments

php · Accepted Answer · 2013-12-12 10:10:22Z

0

Your syntax is wrong... The correct coding is:

 <?php
mysql_connect("localhost","root","");
mysql_select_db("form1");
$query = mysql_query("SELECT * FROM users WHERE name = 'Admin' ");
while($rows = mysql_fetch_array($query))
{

   $rows = $rows['Name'];
   $address = $rows['Address'];
   $email = $rows['Email'];
   $subject = $rows['Subject'];
   $comment = $rows['Comment']
   echo $rows.'</br>'.$address.'</br>'.$email.'</br>'.$subject.'</br>'.$comment;
}
   ?>

answered Dec 12, 2013 at 10:10

php

4,4551 gold badge27 silver badges13 bronze badges

Comments

user6091934 · Accepted Answer · 2016-10-21 05:11:56Z

0

<table border="1px">

    <tr>
        <th>Student Name</th>
        <th>Email</th>
        <th>password</th>
    </tr>

        <?php

            If(mysql_num_rows($result)>0)
            {
                while($rows=mysql_fetch_array($result))
                {  

        ?>
    <?php echo "<tr>";?>
                    <td><?php echo $rows['userName'];?> </td>
                    <td><?php echo $rows['email'];?></td>
                    <td><?php echo $rows['password'];?></td>

    <?php echo "</tr>";?>
        <?php
                }
            }

    ?>
</table>
    <?php
        }
    ?>

answered Oct 21, 2016 at 5:11

user6091934

91 bronze badge

1 Comment

ρяσѕρєя K Over a year ago

Add some explanation with answer for how this answer help OP in fixing current issue

Dipesh Parmar · Accepted Answer · 2013-02-12 07:20:03Z

-1

Try

$query = mysql_query("SELECT * FROM users WHERE name = 'Admin' ")or die(mysql_error());

and check if this throw any error.

Then use while($rows = mysql_fetch_assoc($query)):

And finally display it as

echo $name . "<br/>" . $address . "<br/>" . $email . "<br/>" . $subject . "<br/>" . $comment . "<br/><br/>" . ;

Do not user mysql_* as its deprecated.

answered Feb 12, 2013 at 7:20

Dipesh Parmar

27.3k8 gold badges65 silver badges92 bronze badges

Comments

Yogesh Suthar · Accepted Answer · 2013-02-12 07:23:10Z

-1

use this code

  while ($rows = mysql_fetch_array($query)):

   $name = $rows['Name'];
   $address = $rows['Address'];
   $email = $rows['Email'];
   $subject = $rows['Subject'];
   $comment = $rows['Comment'];

   echo "$name<br>$address<br>$email<br>$subject<br>$comment<br><br>";

   endwhile;

   ?>

answered Feb 12, 2013 at 7:23

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

1 Comment

Dharman Over a year ago

Why should anyone use this code? This extension was removed from PHP. At the time of writing this post it was already in the process of deprecation.

Nagama Inamdar · Accepted Answer · 2016-06-22 10:43:44Z

-1

Code:

while ($rows = mysql_fetch_array($query)):
       $name = $rows['Name'];
       $address = $rows['Address'];
       $email = $rows['Email'];
       $subject = $rows['Subject'];
       $comment = $rows['Comment']
       echo "$name<br>$address<br>$email<br>$subject<br>$comment<br><br>";
endwhile;

edited Jun 22, 2016 at 10:43

Nagama Inamdar

2,85522 gold badges41 silver badges50 bronze badges

answered Jun 22, 2016 at 9:51

test

1

Collectives™ on Stack Overflow

What is wrong with this code that uses the mysql extension to fetch data from a database in PHP?

10 Answers 10

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

10 Answers 10

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related