Java - Assigning arguments to multiple variables in constructor

Question

I've searched online and cannot find an answer. Is it improper to assign an argument to more than one variable in a constructor or does there have to be a one-to-one relationship?

public A6HangmanLogic(String keyPhrase, int numberOfGuesses)
{
    this.keyPhrase = keyPhrase;
    this.numberOfGuesses = numberOfGuesses;
    guessesLeft = numberOfGuesses;
}

The value of guessesLeft (a static int) is returned from an accessor method updated through a loop. I can certainly write a mutator method, but then I have to call it. I could also change this.numberOfGuesses to just guesses and not have that third variable assignment at all.

It's fine. However if you find you're getting too much code in your constructor, just create another method and call that. — vikingsteve
– vikingsteve, Commented Feb 24, 2013 at 21:33

Bohemian · Accepted Answer · 2013-02-24 21:41:01Z

2

It's fine, but I would store guessCount and use the default initualized value of zero:

private guessCount;

I would also rename numberOfGuesses to maxGuesses so it's clearer what it means (it's also more conventional).

answered Feb 24, 2013 at 21:41

Bohemian♦

427k103 gold badges603 silver badges750 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

drone-ah · Accepted Answer · 2013-02-24 21:28:32Z

1

There is no reason why you can't assign the same value to multiple variables.

Another way to solve the problem though might be to store the number of guesses made and then calculate the number of guesses left.

answered Feb 24, 2013 at 21:28

drone-ah

1,15314 silver badges29 bronze badges

Comments

score 0 · Accepted Answer · 2013-02-24 21:35:14Z

0

Yes, it's perfectly fine to assign an argument to as many variables as you like.

You are allowed to use them in a similar way as you would in a method.

edited Feb 24, 2013 at 21:35

answered Feb 24, 2013 at 21:30

user2030471

Collectives™ on Stack Overflow

Java - Assigning arguments to multiple variables in constructor

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related