PHP set form values

Question

I'm kinda rookie at PHP but i'm trying to developing a backoffice with some tables and value-editing options.

By now, i have tables like this:

enter image description here

But i'm kinda bugged with this issue:

The change button is being implemented like this:

for ($i = 0; $i < count($a); $i++) {
            ?>
            <tr>
            <td><i onclick="
            document.form1.deviceFeatValID.value = <?php echo $a[$i][DEVICE_FEATURE_VALUE_ID] ?>;
            document.form1.deviceID.value = <?php echo $a[$i][DEVICE_ID] ?>;
            document.form1.deviceClassFeatID.value = <?php echo $a[$i][DEVICE_CLASS_FEATURE_ID] ?>;
            document.form1.deviceFeatureVal.value = <?php echo $a[$i][DEVICE_FEATURE_VALUE] ?>;
            document.form1.submit();" class="icon-refresh" ></td>
            <td><?php echo $a[$i]['DEVICE_FEATURE_VALUE_ID']; ?><td><?php echo $a[$i]['DEVICE_ID']; ?><td><?php echo $a[$i]['DEVICE_CLASS_FEATURE_ID']; ?><td><?php echo $a[$i]['DEVICE_FEATURE_VALUE']; ?>
            </tr>
            <?php
            }
            ?>

That is, by Javascript, i set the input values of this form, in the same .php:

<form name="form1" method="post" action="deviceFeatureValueFRM.php">
            <input type="hidden" name="deviceFeatValID"/>
            <input type="hidden" name="deviceID"/>
            <input type="hidden" name="deviceClassFeatID"/>
            <input type="hidden" name="deviceFeatureVal"/>
            <input type="hidden" name="hiddenTypeField"/>
        </form>

But...do you consider that this is a good practice? Is there another solution?!

The goal of this code is to detect which line is going about to be edited.

Kind regards,

Sam

Yes. Why not define them in PHP? Also, you're using obtrusive JS which is bad practice, too... — BenM
– BenM, Commented Mar 7, 2013 at 13:07
I already tryed: I left that form intact, and instead the refresh icon, i used the submit input button. But how can i set each form hidden inputs by php? Thank you for your fast response BenM :) — Sammy
– Sammy, Commented Mar 7, 2013 at 13:11

SeanWM · Accepted Answer · 2013-03-07 13:09:47Z

2

Why do this with javascript? Just give the input field a value as such:

<input type="hidden" name="deviceFeatValID" value="<?php echo $a; ?>"/>

Where $a can be any variable you would like.

answered Mar 7, 2013 at 13:09

SeanWM

17.1k10 gold badges54 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Sammy Over a year ago

But the form aims to another page and i want to know which input submit button was pressed :). Thank you for your fast response SeanWM :)

BenM Over a year ago

You can easily detect which submit element was clicked by assigning them with different names (or values)...

Sammy Over a year ago

Ok, that's possible if you have a fixed number of buttons. But in my case i don't know, at first glance how many rows i'm gonna have :S Thank you for your fast response :)

Sammy Over a year ago

And you say assign different names how? By concatenating strings?

Tolke · Accepted Answer · 2013-03-07 13:14:48Z

0

Well, I would recommend that you had all files separately. So let's say you had one file for PHP. One file for Javascript, and one for HTML. So if you want to use php functions or whatever just need to call them via AJAX.

That way you will have a cleaner code and a bit more secure one.

answered Mar 7, 2013 at 13:14

Tolke

1981 silver badge14 bronze badges

1 Comment

Sammy Over a year ago

Thank you for your fast response. I already set up multiple files once, and i know that the example i put in the question isn't perfect :). But i have priority in trying to avoid javascript in the passage of parameters on the form, by clicking the change button and knowing precisely which button was pressed :)

Collectives™ on Stack Overflow

PHP set form values

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related