Printing array error

Question

This is probably a simple fix, but I am just not seeing it. I am trying to figure out, how do I get my printOut() method to print properly from the main Project5PartA? Do I need get, set, and return methods? Also, is my while loop even necessary in the Tester class?

The program compiles and keeps running to infinity, so I guess the while loop is wrong. But it also only prints out [Ljava.lang.String;@7c1c8c58 continuously on each line.

The classes that extend the main are irrelevant and part of the project. Apologies if this was posted wrong and thanks for any help.

The output of the whole program would be similar to:

Bark, bark.

Meow, meow.

Roooaaar.

Dog says woof, woof.

Cat says meow, meow.

Tester Class:

public class Tester {

String[] animalArray = {"Dog", "Cat", "tRex", "Cow", "Pig", "Snake",
    "Goat", "Owl", "Chicken", "Frog"};

String[] noiseArray = {"Woof, woof", "Meow, meow", "Roooaaar", "Mooo",
    "Oink, oink", "Hissss", "Baaa", "Hoot, hoot", "Bock, bock",
    "Ribbit, ribbit"};

String[] printArray = new String[10];

public String printOut() {
    while (true) {
        for (int i = 0; i < 10; i++) {

            String value = (animalArray[i] + " says " + noiseArray[i] + ".");
            printArray[i] = value;

            System.out.println();
            System.out.println(printArray);
            break;

        }
    }
}
}

Wow I feel very very stupid. Completely forgot about the Arrays.toString(). Everyone who posted helped, sucks I can only choose one. Again, thank you all! — user1422051
– user1422051, Commented Mar 19, 2013 at 21:18

syb0rg · Accepted Answer · 2013-03-19 21:14:29Z

2

Use Arrays.toString() to print the contents of an array. Don't actually print the array itself.

System.out.println(printArray); // Prints [Ljava.lang.String;@7c1c8c58 
System.out.println(Arrays.toString(printArray0); // Prints [Dog says Woof, woof...]

If you do use Arrays.toString(), print the array outside the loops. You could also just print each part of the array with System.out.println(printArray[i]) inside the loop.

public String printOut() {
    while (true) {
        for (int i = 0; i < 10; i++) {

            String value = (animalArray[i] + " says " + noiseArray[i] + ".");
            printArray[i] = value;
            System.out.println();
            System.out.println(printArray[i]); // This works
            break;
        }
    }
    System.out.println(Arrays.toString(printArray); // Also works
}

edited Mar 19, 2013 at 21:14

answered Mar 19, 2013 at 21:08

syb0rg

8,24710 gold badges43 silver badges82 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

emd · Accepted Answer · 2013-03-19 21:06:49Z

1

Because printArray is array and doesn't have a toString() method you will have to print out each element seperatly or use Arrays.toString(printArray) method.

Something like this will get you a growing array if it's in the while loop. Place it outside the while loop:

System.out.println(Arrays.toString(printArray));

Or in the while loop:

System.out.println(printArray[i]);

answered Mar 19, 2013 at 21:06

emd

7504 silver badges12 bronze badges

Comments

Aaron Kurtzhals · Accepted Answer · 2013-03-19 21:07:08Z

1

You don't need the while loop unless you really want your program to run forever.

You should change your print statement as follows. (You were printing the array object, not the array contents.)

System.out.println(printArray[i]);

answered Mar 19, 2013 at 21:07

Aaron Kurtzhals

2,0343 gold badges17 silver badges22 bronze badges

Collectives™ on Stack Overflow

Printing array error

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related