What is wrong with my IF statement in javascript & jquery?

Question

Basically I am hacking a foxycart setup I run and I need to basically hide a certain shipping option should a few things on the page exist...

1) that $value != United States (this is pulled dynamically from a text input but for purposes of showing you I've made it a static variable here
2) the number '.fc_cart_item' occurs is only once
3) the text in '.fc_cart_item_quantity' is only 1
and
4) the text in #fc_cart_table contains either Xyz or Zyx

Here is my statement that kinda works...

 var value = 'Australia';

if(    
    (    $value != 'United States'    &&    $('.fc_cart_item').size() < 2    &&    $('.fc_cart_item_quantity').text() < 2    )    &&    
    (    $('#fc_cart_table:contains(\'Zyx\')')    ||    $('#fc_cart_table:contains(\'Xyz\')')    )    
)

    {

       // do stuff

     }

Now this was working (whatever I put in // do stuff would occur) as I expect it when I had Xyz or Zyx in the cart... but then it was still doing stuff even when it was something other than Xyz or Zyx.

I'm coming from a PHP background so I don't know if I'm doing my if statement correctly here.

Zoli · Accepted Answer · 2009-10-14 11:18:59Z

1

The if statement in your example will always return true because of the fact that the :contains selector does not return a boolean value that can be used safely for an if statement. Try this instead:

value = "Australia";

if( ( value != "United States" &&  $(".fc_cart_item").size() < 2 &&
   $(".fc_cart_item_quantity").text() < 2   ) &&
   ( $("#fc_cart_table").is(":contains('Zyx')") ||
   $("#fc_cart_table").is(":contains('Xyz')")    ) 
{

   // do stuff
}

BTW, your can tell that you're from a PHP background with your $value syntax... :)

edited Oct 14, 2009 at 11:18

answered Oct 14, 2009 at 10:48

Zoli

1,1477 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

simon · Accepted Answer · 2009-10-14 10:45:26Z

1

It's "doing stuff" when these conditions are met:


$value != 'United States'    &&    $('.fc_cart_item').size() < 2    &&    $('.fc_cart_item_quantity').text() < 2    )

even if there is no Zyx or Xyz in the cart.

answered Oct 14, 2009 at 10:45

simon

13k27 gold badges83 silver badges117 bronze badges

Comments

MrMage · Accepted Answer · 2009-10-14 10:49:41Z

1

Try the following. Notice that variables do not get accessed by $value but by value. You should also not check for $('#fc_cart_table:contains(\'Zyx\')') - the result is an empty array which is boolean evaluated as true. Rather use either $('#fc_cart_table:contains(\'Zyx\')').size() or as used below:

var value = 'Australia';

if(    
    (    value != 'United States'    &&    $('.fc_cart_item').size() < 2    &&    parseInt($('.fc_cart_item_quantity').text()) < 2    )    &&    
    (    $('#fc_cart_table').text().indexOf('Zyx') > -1    ||    $('#fc_cart_table').text().indexOf('Xyz') > -1    )    
)
{
    // do stuff
}

/edit: I also added a parseInt() statement just for proper type usage's sake.

answered Oct 14, 2009 at 10:49

MrMage

7,5463 gold badges46 silver badges74 bronze badges

1 Comment

willdanceforfun Over a year ago

thanks MrMage. I chose zdawgs because it was less code. yours worked also!

powtac · Accepted Answer · 2009-10-14 11:31:17Z

1

Remove the $ before value. And put parseInt() arround $('.fc_cart_item_quantity').text().

answered Oct 14, 2009 at 11:31

powtac

41.1k28 gold badges120 silver badges173 bronze badges

1 Comment

MrMage Over a year ago

That's not sufficient, as mentioned in the other answers.

Collectives™ on Stack Overflow

What is wrong with my IF statement in javascript & jquery?

4 Answers 4

Comments

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related