Object Oriented Programming accessing variable values, How to?

Question

I am a learner, I have a class db to help me connect and fetch results in mySQL.

$set = $db->get_row("SELECT * FROM users");
echo $set->name;

this way i use echo results outside a class.

Now i have created another class name user and it has this function

public function name() {
            global $db;
            $set = $db->get_row("SELECT * FROM users");
            $this->name = $set->name;
    }

after initializing the class user, when i try to echo $user->name i dont get expected results.

Note i have declared above var $name; in class user

For one thing, using var is deprecated.

slikts
– slikts

2009-10-15 16:17:00 +00:00
Commented Oct 15, 2009 at 16:17 — slikts
– slikts, Commented Oct 15, 2009 at 16:17

Peter Bailey · Accepted Answer · 2009-10-15 16:27:51Z

I'm pretty concerned by several things I see here

The method name name() is terribly uncommunicative as to what the method is supposed to do. Remember, methods are actions - try to give them some sort of verb in their name.
Usage of global in a class (or even usage of global period) when you should be using aggregation or composition.
You don't show any execution examples, but I can only assume you never actually call User::name(), which is why your test is failing

Here's some code that addresses these concerns.

<?php

class DB
{
  /* Your methods and stuff here */
}

class User
{
  protected $db;
  protected $name;

  public function __construct( DB $db )
  {
    $this->db = $db;
  }

  public function getName()
  {
    if ( is_null( $this->name ) )
    {
      $set = $this->db->get_row( "SELECT * FROM users" );
      $this->name = $set->name;  
    }
    return $this->name;
  }
}

$db = new DB();

$user = new User( $db );
echo $user->getName();

Lizard · Accepted Answer · 2009-10-15 16:24:40Z

1

class DB
{
    public function get_row($q)
    {
        # do query and store in object
        return $object;
    }
}

class User
{
    public $name;

    public function __construct()
    {
        $this->name();
    }

    public function name() {
        global $db;
        $set = $db->get_row("SELECT * FROM users");
        echo "<pre>".print_r($set)."</pre>"; # make sure $set is returning what you expected.
        $this->name = $set->name;
    }
}

$db = new DB();
$user = new User();
echo $user->name;

edited Oct 15, 2009 at 16:24

answered Oct 15, 2009 at 16:18

Lizard

45.3k39 gold badges108 silver badges170 bronze badges

1 Comment

Lizard Over a year ago

Were you missing the constructor?

Shishant · Accepted Answer · 2009-10-15 16:25:46Z

0

I am very much sorry, i figured out that problem was on my part, i was using cookies and had two cookies set which were giving problems :(

answered Oct 15, 2009 at 16:25

Shishant

9,31415 gold badges60 silver badges82 bronze badges

Collectives™ on Stack Overflow

Object Oriented Programming accessing variable values, How to?

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related