List Array and String Array / multi-line string inside of nested loop in Android Java

Question

I've got a string with many lines and in each line contains a number of elements. I'm only after a third element of each line. Is there anything from with this chunk of code?

String[] separate = getArray().split("\n");
for (int i = 0; i < separate.length; i++)
{
    String[] inner = separate[i].split("/");
    for (int y = 0; y < inner.length; y++)
    {
        _listArray.add(String.valueOf(inner[2]));                   
    }
}

it's not doing what it's supposed to, or maybe I'm just too tired.

You have to describe the problem better than "it's not doing what it's supposed to". How is it not working? — Jim Garrison
– Jim Garrison, Commented Apr 16, 2013 at 18:38
Are you sure that getArray() returns the original string in the correct format with all the lines separated by \n ? — Μenelaοs
– Μenelaοs, Commented Apr 16, 2013 at 18:41
Why are you calling String.valueOf( )? inner[2] is already a String — Mel Nicholson
– Mel Nicholson, Commented Apr 16, 2013 at 18:41

Mel Nicholson · Accepted Answer · 2013-04-16 18:44:22Z

3

The inner loop is not needed.

String[] lines = getArray().split("\n");
for (String line : lines) {
  String[] tokens = line.split("/");
  _listArray.add(tokens[2]);
}

You may want a safety to make sure that tokens.length >= 2

answered Apr 16, 2013 at 18:44

Mel Nicholson

3,22416 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jatin · Accepted Answer · 2013-04-16 18:44:35Z

2

Isn't it suppose to be:

String[] separate = getArray().split("\n");
for (int i = 0; i < separate.length; i++)
{
String[] inner = separate[i].split("/");
if(inner.length<3)
     throw new RuntimeException("Wrong data");//or ignore line as desire
else _listArray.add(String.valueOf(inner[2]));                   
}

answered Apr 16, 2013 at 18:44

Jatin

31.8k16 gold badges102 silver badges173 bronze badges

Collectives™ on Stack Overflow

List Array and String Array / multi-line string inside of nested loop in Android Java

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related