C# code refactor (lambda expression)

Question

I am trying to verify that there is a file with a certain filename in a zip file. Is there a better way to do it than the following?

        using (ZipArchive archive = ZipFile.OpenRead(zipFilePath))
        {
            if (!archive.Entries.Any(e => e.Name.Equals(FileNameToCheckFor)))
            {
                // Throw an exception
            }

            foreach (ZipArchiveEntry file in archive.Entries)
            {
                // Do some processing. This is unrelated.
            }
        }

Looks perfectly OK to me. Except I prefer to use var instead of the type name in the using for example: using (var archive = ...) — Fede
– Fede, Commented May 7, 2013 at 0:08
That seems pretty reasonable except that you're enumerating the list of entries twice. If there's a way to better organize your work you could probably avoid that. The importance of this is dependent on the size of the zip files as ripping through a 2PB Zip file twice is probably a bad idea... — Chris M.
– Chris M., Commented May 7, 2013 at 0:08
@Chris surely the zip format has an index of files at the start.. — Blorgbeard
– Blorgbeard, Commented May 7, 2013 at 0:09
What about this instead? if (archive.GetEntry(ExportFileName) == null) — allenwoot
– allenwoot, Commented May 7, 2013 at 0:21

drf · Accepted Answer · 2013-05-07 00:25:17Z

4

Since ZipArchive.GetEntry returns null if the entry does not exist, you could replace the lambda expression with:

 if (archive.GetEntry(FileNameToCheckFor) == null)
 {
      // Throw an exception
 }

This is slightly more concise, but that is not to imply anything incorrect about the original code.

edited May 7, 2013 at 0:25

answered May 7, 2013 at 0:18

drf

8,75935 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

C# code refactor (lambda expression)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related