mysqli insert multiple rows from a loop

Question

I am trying to insert multiple rows based on a loop.
This code inserts the first item from the loop only, then ignores the rest of the loop
I know the loop is counting correctly as echo'ing out the values outputs ok

$i = 1;
while ($i <= $count){

    foreach($html->find('.markuptag a') as $mystring){
        if(preg_match_all("|<a.*(?=href=\"([^\"]*)\")[^>]*>([^<]*)</a>|i", $mystring, $matches)){
            $a = $matches[2][0];
         }

        $query = "INSERT INTO mytable (`firstname`, `lastname`, `var_a`) VALUES ('$fistname', '$lastname', '$a')";

        $mysqli->query($query);//<< is there a better way?

    }
    $i++;
}

Niet the Dark Absol · Accepted Answer · 2013-05-26 01:38:17Z

5

Build an array of the rows to insert, then insert them all at once. Something like this:

$arr = []; // array() in PHP 5.3 and older
foreach(...) {
    ...
    $arr[] = "('$fistname', '$lastname', '$a')";
}
$mysqli->query("INSERT INTO mytable (`firstname`, `lastname`, `var_a`) VALUES "
    .implode(",",$arr));

answered May 26, 2013 at 1:38

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

s_p Over a year ago

how would this work if i need to capture the $thisID = $mysqli->insert_id of each of the arr?

Niet the Dark Absol Over a year ago

Hmm... You could get that ID still, it should be the ID of the last row inserted, then subtract count($arr)-1 to get the ID of the first, and work from there.

Collectives™ on Stack Overflow

mysqli insert multiple rows from a loop

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related