javascript inline callback function to separate function

Question

Why is this code working:

function onCordovaReady() { 
    navigator.globalization.getLocaleName(function (locale) {
        jQuery.i18n.properties({
            name:'message', 
            path:'lang/', 
            mode:'map',
            language:locale.value,
            callback: function(){
                alert(locale.value);
                alert(jQuery.i18n.prop('msg_hello'));
                alert(jQuery.i18n.prop('msg_complex', 'John'));
            }
        });
    });
}

And this one not:

function onCordovaReady() { 
    navigator.globalization.getLocaleName(function (locale) {
        jQuery.i18n.properties({
            name:'message', 
            path:'lang/', 
            mode:'map',
            language:locale.value,
            callback: onLanguageReady(locale)
        });
    });
}

function onLanguageReady(locale) {
     alert(locale.value);
     alert(jQuery.i18n.prop('msg_hello'));
     alert(jQuery.i18n.prop('msg_complex', 'John'));    
}

I want to make the callback in a different function so my code will look cleaner, but couldn't get it to work. The first alert will work (it will display nl_NL), but the second and third alert will output [msg_hello] and [msg_complex].

Many thanks!

romainberger · Accepted Answer · 2013-05-29 08:39:19Z

3

Try with this:

// beginning of code omitted
callback: function(locale) {
    onLanguageReady(locale)
}

answered May 29, 2013 at 8:39

romainberger

4,5582 gold badges37 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Denny Beulen Over a year ago

This does not work completely, it works if i remove the line: alert(locale.value); When i leave the line in there the javascript code just freezes.

romainberger Over a year ago

Where is the locale variable defined?

Denny Beulen Over a year ago

I guess it is defined in navigator.globalization.getLocaleName this is from the cordova/phonegap plugin. link

Arun P Johny · Accepted Answer · 2013-05-29 08:39:45Z

2

it is because you are assigning undefined to the callback property.

You are calling onLanguageReady and assigns that value to the callback method.

The solution is to use another function as callback function which will call the onLanguageReady function as given by @romainberger

answered May 29, 2013 at 8:39

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Comments

Baz1nga · Accepted Answer · 2013-05-29 08:39:42Z

0

function onCordovaReady() { 
    navigator.globalization.getLocaleName(function (locale) {
        jQuery.i18n.properties({
            name:'message', 
            path:'lang/', 
            mode:'map',
            language:locale.value,
            callback: onLanguageReady
        });
    });
}

function onLanguageReady(locale) {
     alert(locale.value);
     alert(jQuery.i18n.prop('msg_hello'));
     alert(jQuery.i18n.prop('msg_complex', 'John'));    
}

will work if the function calls back with locale.

the callback is expecting a function pointer that it can call once the processing is done when you say onLanguageReady(locale) you are actually executing the function and thus assigning the result of the function as the call back in this case the return is nothing thus undefined

answered May 29, 2013 at 8:39

Baz1nga

15.6k3 gold badges38 silver badges63 bronze badges

1 Comment

Denny Beulen Over a year ago

this works if i remove the alert(locale.value); line, but i also need locale.value

Collectives™ on Stack Overflow

javascript inline callback function to separate function

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related