dynamically adding controls under loop in C#

Question

I am developing a windows application where I want to create some controls dynamically inside a loop. The code I am trying is

private Label newLabel = new Label();
private int txtBoxStartPosition = 100;
private int txtBoxStartPositionV = 25;

 for (int i = 0; i < 7; i++)
{

    newLabel.Location = new System.Drawing.Point(txtBoxStartPosition, txtBoxStartPositionV);
    newLabel.Size = new System.Drawing.Size(70, 40);
    newLabel.Text = i.ToString();

    panel1.Controls.Add(newLabel);
    txtBoxStartPositionV += 30;


}

This code is generating only one Label with text 7 but I want to create 8 Lables with their respective texts, how can I do this?

Andrei · Accepted Answer · 2013-06-04 09:38:49Z

4

In your loop you are essentially updating properties of the very same Label. If you want create a new one on each step, move creation of the object inside the loop:

private Label newLabel;

for (int i = 0; i < 7; i++)
{
    newLabel = new Label();
    ...

By the way if you want 8 labels - your for should iterate 8 times, not 7, as it does now:

for (int i = 0; i < 8; i++)

answered Jun 4, 2013 at 9:38

Andrei

56.8k10 gold badges92 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

omer schleifer · Accepted Answer · 2013-06-04 09:38:23Z

3

Try this:

private int txtBoxStartPosition = 100;
private int txtBoxStartPositionV = 25;

 for (int i = 0; i < 7; i++)
{
    newLabel = new Label();
    newLabel.Location = new System.Drawing.Point(txtBoxStartPosition, txtBoxStartPositionV);
    newLabel.Size = new System.Drawing.Size(70, 40);
    newLabel.Text = i.ToString();

    panel1.Controls.Add(newLabel);
    txtBoxStartPositionV += 30;


}

answered Jun 4, 2013 at 9:38

omer schleifer

3,9455 gold badges34 silver badges43 bronze badges

Comments

Ɖiamond ǤeezeƦ · Accepted Answer · 2013-06-04 09:38:01Z

1

You need to put the line private Label newLabel = new Label(); in the for loop.

private int txtBoxStartPosition = 100;
private int txtBoxStartPositionV = 25;

for (int i = 0; i < 7; i++)
{
    Label newLabel = new Label();
    newLabel.Location = new System.Drawing.Point(txtBoxStartPosition, txtBoxStartPositionV);
    newLabel.Size = new System.Drawing.Size(70, 40);
    newLabel.Text = i.ToString();

    panel1.Controls.Add(newLabel);
    txtBoxStartPositionV += 30;
}

answered Jun 4, 2013 at 9:38

Ɖiamond ǤeezeƦ

3,3413 gold badges32 silver badges42 bronze badges

2 Comments

Ɖiamond ǤeezeƦ Over a year ago

Remove private from the line as per the example.

Arran Over a year ago

You didn't say that to begin with ;)

Collectives™ on Stack Overflow

dynamically adding controls under loop in C#

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related