jQuery bind function from inside another function

Question

I have this sample code. What I need is to run the function once on load and bind it to change event. The conditional run is required.

if (true) {
    Settings.customImage();
}

Settings.customImage = function() {
    var imageInput = $("#imageInput");
    var imagePreview = $('#imagePreview');

    updateCustomImage();
    imageInput.bind('change', updateCustomImage());

    function updateCustomImage() {
        var src = imageInput.val();
        alert(src);
        imagePreview.html(src ? '<img src="' + src + '">' : '');
    }
}

"The conditional run is required." - Not for purposes of this question: it's just a pointless complication if the condition is hardcoded to true. @pXL - If your edit had been a suggested edit in need of review it would've been rejected as "too minor", I mean, really was that exclamation mark such a problem? — nnnnnn
– nnnnnn, Commented Jun 14, 2013 at 9:08

Arun P Johny · Accepted Answer · 2013-06-14 09:04:45Z

1

You need to pass a function reference as the callback to bind function. In your code your are calling the function updateCustomImage and passing its return value (in this case undefined) as the change callback.

It should be

imageInput.bind('change', updateCustomImage);

answered Jun 14, 2013 at 9:04

Arun P Johny

389k68 gold badges532 silver badges532 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Emil A. · Accepted Answer · 2013-06-14 09:07:15Z

0

You need to pass a reference to the function

imageInput.bind('change', updateCustomImage);

or just use an anonymous function

imageInput.bind('change', function () {
    var src = imageInput.val();
    alert(src);
    imagePreview.html(src ? '<img src="' + src + '">' : '');
});

answered Jun 14, 2013 at 9:07

Emil A.

3,4455 gold badges31 silver badges47 bronze badges

Collectives™ on Stack Overflow

jQuery bind function from inside another function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related