Saving Byte[] Array to MYSQL

Question

Possibly Answered Here: storing image to byte[] into Mysql using asp.net and c#

using System.Drawing;
using System.Drawing.Imaging;

var imageBytes = imageToByteArray(pictureBox1.Image);     

var insert = new MySqlCommand("Insert INTO itemimage set imageName = '" + imageBytes + "'", _con);

insert.ExecuteNonQuery();   


public byte[] imageToByteArray(Image imageIn)
{
    var ms = new MemoryStream();
    imageIn.Save(ms, ImageFormat.Gif);
    return ms.ToArray();
}

Table: itemimage
2 | System.Byte[]  | 13byte    

3 | System.Byte[]  | 13byte

What is wrong with this code? thanks.

Jon Skeet · Accepted Answer · 2013-06-19 07:53:16Z

5

What is wrong with this code?

You're using string concatenation to form the SQL. That's calling ToString on a byte array, which gives System.Byte[] as the result.

Instead, use a parameterized query, and set the parameter value to your byte array.

Something like this:

var data = ImageToByteArray(pictureBox.Image);
using (var cmd = new MySqlCommand("INSERT INTO itemimage SET imageName = @image",
                                  _con))
{
    cmd.Parameters.Add("@image", MySqlDbType.Blob).Value = data;
    cmd.ExecuteNonQuery();
}

Mind you, I'm a bit concerned about the column name here - is it really meant to be the name of an image (which is what the column name suggests) or the data in an image (which is what your code suggests)? Those are two very different things, and you should make it clear which is which.

You should always use parameterized queries:

They prevent SQL injection attacks
They reduce data conversion issues
They separate the code from the data more cleanly

answered Jun 19, 2013 at 7:53

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

rahstame Over a year ago

Can you do an example code sir Jon, sorry noob here. Thanks for your consideration.

rahstame Over a year ago

right now I got: (Binary/Image). Once again, thank you for being generous with your example. Now I can understand more. I hope this could also help other people like me. Good Day.!

C4d Over a year ago

Yeah for sure. Got the same issue. Same solution worked. Upvoted. Thanks for this a lot! :)

Collectives™ on Stack Overflow

Saving Byte[] Array to MYSQL

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related