Invalid JSON primitive While parsing JSON in MVC Controller

Question

I am creating a JSON string in my JavaScript and sending it to my controller in mvc application. My code which create JSON string :

     $('#btnassign').click(function () {

            var arrPrice = "";
            var arrMarkUP = "";

            $("table tr").each(function () {

                if ($(this).find('input:checkbox:first').is(':checked')) {

                    if ($(this).find('input.inputprice').val() != "") {
                        arrPrice += "{";
                        var price = $(this).find('input.inputprice').val();
                        var id = $(this).find('input[type=hidden]').val();
                        arrPrice += '"Id":"' + id + '","Price":"' + price + '"';
                        arrPrice += "},";
                    }
                    if ($(this).find('input.inputmarkup').val() != "") {
                        arrMarkUP += "{";
                        var price = $(this).find('input.inputmarkup').val();
                        var id = $(this).find('input[type=hidden]').val();
                        arrMarkUP += "Id:" + id + ",Price:" + price;
                        arrMarkUP += "},";
                    }
                }
            });

            var lastindexp = arrPrice.lastIndexOf(",");
            arrPrice = arrPrice.substring(0, lastindexp) + "|";
            var lastindexm = arrMarkUP.lastIndexOf(",");
            arrMarkUP = arrMarkUP.substring(0, lastindexm) + "|";
            alert(arrPrice);
            alert(arrMarkUP);

            $("#hdPrice").val(arrPrice);
            $("#hdMarkUP").val(arrMarkUP);

            $("#AssignProductForm").submit();
        });

    });

My JSON string generates from above code :

    {"Id":"1","Price":"4"},{"Id":"2","Price":"6"}

My Controller parsing code :

    [HttpPost]
    public ActionResult AddProducts(FormCollection collection, string txtsearch)
    {
        var ManualPricing = collection["hdPrice"].Split(new char[] { '|' }, StringSplitOptions.RemoveEmptyEntries);

         JavaScriptSerializer ser = new JavaScriptSerializer();
         var Manual = ser.Deserialize<PriceMargin>(ManualPricing[0]);         
    }

Price margin is a class to which it should deserialize :

    public class PriceMargin
    {
        public string Id { get; set; }
        public string Price { get; set; }
    }

Line var Manual = ser.Deserialize<PriceMargin>(ManualPricing[0]) gives me an error:

Invalid JSON primitive: {"Id":"2","Price":"9"}.

Solution:

var list = new JavaScriptSerializer().Deserialize<List<KeyValue>>(json);

public class KeyValue
{
   public string key;
   public string value;
}

Why are you manually building the string? You can use native datatypes and then encode those datatypes to JSON strong and decode the JSON string to native datatypes — dm03514
– dm03514, Commented Jul 7, 2013 at 16:34
i don't know how to do it , i am new to javascript , jquery !! any example ? — DharaPPatel
– DharaPPatel, Commented Jul 7, 2013 at 16:36

SLaks · Accepted Answer · 2013-07-07 16:34:25Z

1

Your JSON is invalid.

JSON can only have a single root object.

If you want to have multiple objects, serialize an array.

answered Jul 7, 2013 at 16:34

SLaks

891k182 gold badges1.9k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dm03514 · Accepted Answer · 2013-07-07 16:39:56Z

1

To follow up the comment, if you want an array of objects to you could do something like:

pricesArray = [];
$("table tr").each(function () {
  if ($(this).find('input:checkbox:first').is(':checked')) {
    var price = $(this).find('input.inputprice').val();
    var id = $(this).find('input[type=hidden]').val();
    pricesArray.push({Id : id, Price: price});
  }
});
// pricesArray [{"Id":"1","Price":"4"},{"Id":"2","Price":"6"}]

pricesArray should now contain the data you want, it should be much easier to serialze and desearilze your data and send it around now

answered Jul 7, 2013 at 16:39

dm03514

56.1k18 gold badges117 silver badges147 bronze badges

Comments

Bharat · Accepted Answer · 2020-06-10 06:56:58Z

Last time I encountered that error, I tried to pass an object value direct to the json data... i.e

data = { datavalue: @Object.valueField};

in Json

$.ajax({
    type: "POST",
    url: "/Controller/FunctionToPostTo",
    data: data,
    contentType: "application/json; charset=utf-8",
    dataType: "html",
    success: function (response) {
        alert('Success');
    },
    failure: function (response) {
        alert('Failure');
        alert(response.responseText);
    },
    error: function (response) {
        alert('Error');
        alert(response.responseText);
    }
});

to solve the problem I created a separate variable and assigned the value to it, passing the data value in Ajax I used the JSON.stringify function

var variableHolder = @Object.valueField;
data = { datavalue: variableHolder };

in Json

$.ajax({
    type: "POST",
    url: "/Controller/FunctionToPostTo",
    data: JSON.stringify(data),
    contentType: "application/json; charset=utf-8",
    dataType: "html",
    success: function (response) {
        alert('Success');
    },
    failure: function (response) {
        alert('Failure');
        alert(response.responseText);
    },
    error: function (response) {
        alert('Error');
        alert(response.responseText);
    }
});

Then the problem dissapeared

Collectives™ on Stack Overflow

Invalid JSON primitive While parsing JSON in MVC Controller

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related