Codeigniter does not execute delete query

Question

I have a problem, when I try to run this function in my model it does nothing. The print statement prints out.

DELETE FROM child_participantsWHERE Child_Name='test' andParent_username='tester2'

Which when I run from command line works correctly(the record exists and is deleted). But when I try it from my web application it gives me no error but does not actually delete anything. I know i am passing data correctly because I receive it in my controller and model. What gives?

   function remove_child($username, $participant_name) 
    {
    $where = "`Child_Name`='$participant_name' and`Parent_username`='$username'";
    $this->db->where($where, null, false);
    $this->db->delete($this->child_table); 
    echo $this->db->last_query();
    }

Off topic, but you should leverage codeigniter's query composition code to prevent SQL injection attacks. — Matthew
– Matthew, Commented Jul 8, 2013 at 21:32
The ` signs may cause problems. Try again after removing them from the $where string. If all fails, use a raw_query. Also have a look at the Codeigniter Database Docs — Markus Hofmann
– Markus Hofmann, Commented Jul 8, 2013 at 21:37

OptimusCrime · Accepted Answer · 2013-07-08 23:25:44Z

4

From the documentation:

If you use multiple function calls they will be chained together with AND between them:

Try changing:

$where = "`Child_Name`='$participant_name' and`Parent_username`='$username'";

to

$this->db->where('Child_Name', $participant_name);
$this->db->where('Parent_username', $username);

// translates to WHERE Child_Name='XXX' and Parent_username='XXX'

Hope this helps!

edited Jul 8, 2013 at 23:25

OptimusCrime

14.9k13 gold badges63 silver badges98 bronze badges

answered Jul 8, 2013 at 21:43

Amal

76.8k18 gold badges133 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dasper · Accepted Answer · 2013-07-08 23:24:14Z

Do you get the same results when you break it out into two where method calls? I would do this over how you are using the where method.

$this->db->where('Child_Name',$participant_name);
$this->db->where('Parent_username',$username);
$this->db->delete($this->child_table);

also, turn on the profiler to see all the queries that are being run to make sure there are not other parts of code we cannot see that might be interfering or a transaction not being committed

$this->output->enable_profiler(TRUE);

Another suggestion is the practice of soft deletes so that way your data is not truly gone and also minimizes how much you need to rely on reconstructing your log file. Also to make simple CRUD operations faster you can use a very simple extension of the base model. One that I have used by recommendation is https://github.com/jamierumbelow/codeigniter-base-model

MJ X · Accepted Answer · 2013-07-09 04:36:54Z

0

Check that does your user has delete privilege in the database. if it has than change your code like this:

function remove_child($username, $participant_name) 
{
    $this->db->trans_start();
    $this->db->where('Child_Name',$participant_name);
    $this->db->where('Parent_username',$username);
    $this->db->delete($this->child_table); 
    $this->db->trans_complete();
    return TRUE;
}

i hope that this will solve your problem.

answered Jul 9, 2013 at 4:36

MJ X

9,12413 gold badges85 silver badges124 bronze badges

Collectives™ on Stack Overflow

Codeigniter does not execute delete query

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related