array based on user input, error?

Question

i went over this code several time and i really cant understand why am getting the Error:

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 6
at qrt2.practice.main(practice.java:34)

am using Eclips standard SDK

and the code is :

package qrt2;
import javax.swing.*;

public class practice {

        public static void main(String[] args) {

//creating JOption for the input

            String num1 = JOptionPane.showInputDialog("Enter the first number");
            int x = Integer.parseInt(num1);

            String num2 = JOptionPane.showInputDialog("Enter the first number");
            int y = Integer.parseInt(num2);

            String num3 = JOptionPane.showInputDialog("Enter the first number");
            int z = Integer.parseInt(num3);

            String num4 = JOptionPane.showInputDialog("Enter the first number");
            int v = Integer.parseInt(num4);

            String num5 = JOptionPane.showInputDialog("Enter the first number");
            int h = Integer.parseInt(num5);

            String num6 = JOptionPane.showInputDialog("Enter the first number");
            int k = Integer.parseInt(num6);


//creating array

            int [] ary = new int []{x,y,z,v,h,k};
            int counter;
            for( counter=0;counter<ary.length;counter++);
            System.out.println(counter + " " + ary[counter]);

        }
}

Reimeus · Accepted Answer · 2013-07-12 16:23:18Z

2

Remove the trailing semi colon from the for statement

for (counter = 0; counter < ary.length; counter++);
                                                  ^

By leaving the semi-colon in place counter equals ary.length once it reaches this statement

System.out.println(counter + " " + ary[counter]);

As arrays are zero based this will cause an ArrayIndexOutOfBoundsException

Unless the variable counter is required outside the loop, move it into the for statement initialization section like this

for (int counter=0; counter < ary.length; counter++) {
    System.out.println(counter + " " + ary[counter]);
}

This will make the ary[counter] expression show up immediately a compilation failure. Notice also the braces give clarity of scope.

edited Jul 12, 2013 at 16:23

answered Jul 11, 2013 at 13:15

Reimeus

160k16 gold badges225 silver badges282 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

JREN · Accepted Answer · 2013-07-11 13:16:46Z

2

for(counter=0;counter<ary.length;counter++) {
    System.out.println(counter + " " + ary[counter]);
}

Remove the semicolon and replace it with a curly opening bracket. Then close the curly bracket after your output.

And if you want to apply best practise, you should also declare your counter variable inside your loop like this:

for(int counter = 0; counter < ary.length; counter++) {}

answered Jul 11, 2013 at 13:16

JREN

3,6204 gold badges29 silver badges46 bronze badges

Comments

Aleks G · Accepted Answer · 2013-07-11 13:19:38Z

1

Your problem is in these lines:

for( counter=0;counter<ary.length;counter++);
System.out.println(counter + " " + ary[counter]);

Specicifically, the first of these completes the loop and the second prints a line - after the loop has completed and the counter incremented beyond the length of the array (thus breaking out of the loop). What you need is to print inside the loop, so these two lines should be:

for( counter=0;counter<ary.length;counter++)
    System.out.println(counter + " " + ary[counter]);

(note the removal of semicolon at the end of the first line). Or, to make it even more clear:

for( counter=0;counter<ary.length;counter++) {
    System.out.println(counter + " " + ary[counter]);
}

answered Jul 11, 2013 at 13:19

Aleks G

57.5k34 gold badges180 silver badges280 bronze badges

Comments

Manish Doshi · Accepted Answer · 2013-07-11 13:24:47Z

1

Remove semicolon from for loop.

for (counter = 0; counter < ary.length; counter++)
{
}

edited Jul 11, 2013 at 13:24

answered Jul 11, 2013 at 13:18

Manish Doshi

1,1931 gold badge9 silver badges17 bronze badges

Collectives™ on Stack Overflow

array based on user input, error?

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related