HTML input textbox onChange not working

Question

This is what I have:

<script language="JavaScript">
    function toggle() {
        if (this.value=='1') {
            document.getElementById('dbOn').style.visibility='visible';
        }
        else {
            document.getElementById('dbOn').style.visibility='hidden';
            document.getElementById('dbOff').checked='checked';
        }
    }
</script>

<form action="index" method="post">
    <input type="text" name="iterations" value="1" onChange="toggle()" >

    <input type="radio" name="db" value="OFF" checked="checked" id="dbOff" >OFF<br>
    <input type="radio" name="db" value="ON" id="dbOn" >ON
</form>

The idea is that you will only be allowed to write to the database if you are doing one iteration. Otherwise, I want the "ON" option to become disabled or disappear and for OFF to be checked automatically.

So far, I have tried onChange, onKeyUp and onKeyPress, but none of them appear to work. Any idea what is wrong with my code?

Thanks

When setting the checked property, use a boolean - true/false — Ian
– Ian, Commented Jul 15, 2013 at 18:14

Ian · Accepted Answer · 2013-07-15 18:23:07Z

11

You need to pass a reference to your element when calling the function.

onchange="toggle(this)"

You'll also need a variable for the value in your function:

function toggle(element) {
        if (element.value=='1') {
  ...

}

DEMO: http://jsfiddle.net/axxCH/1/

edited Jul 15, 2013 at 18:23

Ian

51k13 gold badges104 silver badges111 bronze badges

answered Jul 15, 2013 at 18:13

Diodeus - James MacFarlane

115k33 gold badges164 silver badges180 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Ian Over a year ago

That doesn't fix it though, because toggle doesn't define any parameters :)

Arepa Slayer Over a year ago

Of course, how stupid of me. I was using 'this' but forgot to pass the reference. Thank you.

Collectives™ on Stack Overflow

HTML input textbox onChange not working

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related