HTML select not inflating correctly from PHP array

Question

I am trying to create a drop down menu of usernames or a <select> as it's known in HTML. However I am only getting the last value back from my array and I can't figure out why.

PHP

function getUserName($db) {

    try {
        $sql = 'SELECT members.name FROM members';
        $query_an = $db->query($sql);               
        $count = $query_an->rowCount();

        if ($count > 0) {
            while ($row = $query_an->fetch(PDO::FETCH_ASSOC)) {
                $names = array();   
                $names[] = $row['name'];                                
            }
            return $names;          
        }       
    } catch(PDOException $e) {
        die($e->getMessage());
    }
}

HTML

<select>                        
  <?php $names = getUserName($db); foreach($names as $key => $value) { ?>
    <option value="<?php echo $key ?>"><?php echo $value ?></option>
  <?php }?>
</select>

I'm fairly sure the HTML section of my code is solid. I think the error lies in how I'm adding values to my $names array but after staring at it for a half an hour I can't see it. Thanks for any help/fresh eyes.

omma2289 · Accepted Answer · 2013-07-21 20:19:04Z

3

You need to declare your array outside the loop

if ($count > 0) {
    $names = array(); 
    while ($row = $query_an->fetch(PDO::FETCH_ASSOC)) {
        $names[] = $row['name'];                                
    }
    return $names;          
}

answered Jul 21, 2013 at 20:19

omma2289

54.7k8 gold badges66 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Mohammad Masoudian · Accepted Answer · 2013-07-21 20:19:33Z

2

this is emptying your array every time : $names = array();

use this :

while ($row = $query_an->fetch(PDO::FETCH_ASSOC)) {
    $names[] = $row['name'];                                
}

answered Jul 21, 2013 at 20:19

Mohammad Masoudian

3,5017 gold badges29 silver badges45 bronze badges

Comments

keyneom · Accepted Answer · 2013-07-21 20:19:35Z

2

You are creating a new $names array every row then returning the last one. You need to declare the array outside the while loop. The following should work:

function getUserName($db) {

try {
    $sql = 'SELECT members.name FROM members';
    $query_an = $db->query($sql);               
    $count = $query_an->rowCount();

    if ($count > 0) {
        $names = array();
        while ($row = $query_an->fetch(PDO::FETCH_ASSOC)) {
            $names[] = $row['name'];                                
        }
        return $names;          
    }       
} catch(PDOException $e) {
    die($e->getMessage());
}
}

answered Jul 21, 2013 at 20:19

keyneom

82510 silver badges12 bronze badges

Comments

Muc · Accepted Answer · 2013-07-21 20:20:03Z

2

The problem is you're re-initializing the array on every loop:

See:

while ($row = $query_an->fetch(PDO::FETCH_ASSOC)) {
                $names = array();   
                $names[] = $row['name'];                                
            }
            return $names;

Should be:

$names = array(); 
 while ($row = $query_an->fetch(PDO::FETCH_ASSOC)) {                      
                $names[] = $row['name'];                                
            }
            return $names;

answered Jul 21, 2013 at 20:20

Muc

1,5262 gold badges13 silver badges32 bronze badges

Collectives™ on Stack Overflow

HTML select not inflating correctly from PHP array

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related