Delphi, Copy string to Byte array

Question

what i have works, but im looking if there is a faster way to copy a string into a pByteArray

from sysutils

  PByteArray = ^TByteArray;
  TByteArray = array[0..32767] of Byte;

assume a and s are setup correctly

 a:   pByteArray;
 s:   string;

is there a fast way to do this, ie something like copy

  for i := 1 TO Length(s) - 1 do
   a^[i] := Ord(s[i]);

delphi 7

Chau Chee Yang · Accepted Answer · 2009-12-01 08:27:48Z

9

Beware using the Move. If you are using Delphi 2009, it may fail. Instead, use this:

Move(s[1], a^, Length(s) * SizeOf(Char));

You may also use class TEncoding in SysUtils.pas (Delphi 2009/2010++ only) to perform the task.

answered Dec 1, 2009 at 8:27

Chau Chee Yang

20k18 gold badges76 silver badges136 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Marco van de Voort Over a year ago

The for loop doesn't execute if length(s) is zero. To be fully equivalent you need to add a check for if length(s). Added.

Remko · Accepted Answer · 2009-12-01 07:26:28Z

4

You can simply cast it:

  a := @s[1];

The other way around is:

  s := PChar(a);

answered Dec 1, 2009 at 7:26

Remko

7,4003 gold badges35 silver badges53 bronze badges

2 Comments

Rob Kennedy Over a year ago

That doesn't copy anything, and it makes a point to something that isn't what its type says it is.

Remko Over a year ago

True (I assumed the purpose was to access the a string as a bytearray or vice vera)

Christopher Chase · Accepted Answer · 2009-12-01 06:34:45Z

2

never mind, found it

 Move(s[1], a^, Length(s));

answered Dec 1, 2009 at 6:34

Christopher Chase

2,9006 gold badges37 silver badges57 bronze badges

1 Comment

user160694 Over a year ago

Remember to check Length(s) <= SizeOf(a), or you risk a buffer overflow - a string may be bigger than a TByteArray.

Michał Niklas · Accepted Answer · 2009-12-01 06:35:34Z

1

I think you can use move procedure just like in this example

answered Dec 1, 2009 at 6:35

Michał Niklas

54.5k19 gold badges76 silver badges125 bronze badges

Collectives™ on Stack Overflow

Delphi, Copy string to Byte array

4 Answers 4

1 Comment

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related