Javascript error while executing alert function through php

Question

I am using fusion maps in one of my application.

In one of the example i have to pass the value from one map to another charts,

I am facing one problem if the data passed is numeric its displaying alert message correctly but if it is a string it generates an error:

NM is not defined

javascript:alert(NM)()

My code is as below:

$strXML .= "<entity id='" . $rs1['Internal_Id'] . "' value='" . round((($rs1['datap'] /  $sumdata) * 100),2) . "' link='javascript:alert(".($rs1['Internal_Id']) . ")'  />";

If i change the link part (passing single quotes in alert)that is:

$strXML .= "<entity id='" . $rs1['Internal_Id'] . "' value='" . round((($rs1['datap'] /  $sumdata) * 100),2) . "' link='javascript:alert('".($rs1['Internal_Id']) . "')'  />";

It displays invalid xml data.

Please help me on this

Thanks

Pankaj

Yacoby · Accepted Answer · 2009-12-02 13:35:42Z

Use \" rather than ' to surround the JavaScript string.

$strXML .= "<entity id='" . $rs1['Internal_Id'] . "' value='" . round((($rs1['datap'] /  $sumdata) * 100),2) . "' link='javascript:alert(\"".($rs1['Internal_Id']) . "\")'  />";

What is happening is that the xml produced is like so:

<entity id='NM' value='1' link='javascript:alert('NM')'/>

Which as you should be able to see from SOs syntax highlighting ends the value for the link attribute after javascript:alert(' as you are using the same quotes for the javascript as you are using for surrounding the attribute values.

Using a different quote (" rather than ') doesn't end the attribute value (again see the syntax highlighting)

<entity id='NM' value='1' link='javascript:alert("NM")'/>

In PHP we have to escape the quote (Using \) so it isn't interpreted as a special character by the php interpreter and used to end the string, which is why in php you have to write \"

DKSRathore · Accepted Answer · 2009-12-02 13:31:57Z

0

You should change your

ink='javascript:alert('".($rs1['Internal_Id']) . "')'

by

ink='javascript:alert(\"".($rs1['Internal_Id']) . "\")'

answered Dec 2, 2009 at 13:31

DKSRathore

3,0736 gold badges29 silver badges36 bronze badges

5 Comments

Pankaj Khurana Over a year ago

Hi, Thanks for reply but now it shows this error missing ) after argument list

DKSRathore Over a year ago

Seems you $rs1['Internal_Id'] has some non word character like " or , or )

DKSRathore Over a year ago

If u don't mind, can you let us know what is your $rs1['Internal_Id'] value

Pankaj Khurana Over a year ago

Hi, It has a string value like 'AK', 'UK' Even if i am giving static text value its generating an error.

DKSRathore Over a year ago

Pankaj have you seen by reversing the ' with " like 'javascript:alert(\"".($rs1['Internal_Id']) . "\")' by link="javascript:alert('".($rs1['Internal_Id']) . "');\"

Rob Grant · Accepted Answer · 2009-12-02 13:34:24Z

0

Try:

$strXML .= "<entity id='" . $rs1['Internal_Id'] . "' value='" . round((($rs1['datap'] /  $sumdata) * 100),2) . "' link='javascript:alert(\"".($rs1['Internal_Id']) . "\")'  />";

Basically escaping your alert quotation marks :)

answered Dec 2, 2009 at 13:34

Rob Grant

7,3704 gold badges44 silver badges63 bronze badges

1 Comment

Pankaj Khurana Over a year ago

Hi, Thanks for reply but now it shows this error missing ) after argument list

Collectives™ on Stack Overflow

Javascript error while executing alert function through php

3 Answers 3

Comments

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related