Can't get CheckBox to update model in MVC Razor Using Html.CheckBoxFor

Question

There seem to be a lot of questions covering similar ground but I haven't found one which clarifies the issues I'm having.

I am attempting to create a simple task list to look like this (sorry can't post the image):

| CheckBox | Title | DeleteLink |
| CheckBox | Title | DeleteLink |
| CheckBox | Title | DeleteLink |

I am unable to get the checkboxes updating the model (I want a checkbox click to call the relevant controller to set the updated state in the model)

I probably have the wrong controller signature / parameters or something!

Currently if I check a checkbox then delete another task the old checkbox state is rendered (the model has not been updated)

here is my model

namespace TaskList.Models
{
    public class TaskListModel
    {
        public List<TaskItem> Tasks { get; set; }
    }
    public class TaskItem
    {
        [Key]
        public int Id { get; set; }
        public string Title { get; set; }
        public DateTime EntryDateTime { get; set; }
        public bool IsDone { get; set; }
    }
}

here is my view

@using (@Html.BeginForm("Edit", "Home"))
{
    <table>

            @for (int i = 0; i < Model.Tasks.Count; i++)
            {
                <tr>
                    <td>
                        @Html.CheckBoxFor(m => m.Tasks[i].IsDone)
                    </td>
                    <td>
                        @Html.EditorFor(m => m.Tasks[i].Title)
                    </td>
                    <td>
                        @Html.ActionLink("Delete", "Delete", new { id = Model.Tasks[i].Id })
                    </td>
                </tr>
            }

    </table>
}

and my attempt at a controller action (which is not called)

// Mark a task as complete
[HttpPost]
public ActionResult Edit(int id = 0, bool isChecked = false)
{
    // database logic
    TaskItem taskItem = _db.Tasks.Find(id);
    taskItem.IsDone = isChecked;

    _db.SaveChanges();

    return RedirectToAction("Index");
}

as requested the Delete method

// Delete a task
public ActionResult Delete(int id = 0)
{
    if (id > 0)
    {
        // database logic
        TaskItem taskItem = _db.Tasks.Find(id);
        _db.Tasks.Remove(taskItem);

        _db.SaveChanges();
    }

    return RedirectToAction("Index");
}

I've tried adding this javascript to the View

$(function () {
    $(':checkbox').change(function () {
        $.ajax({
            url: '@Url.Action("Edit", "Home")',
            type: 'POST',
            data: { id: $(this).id, isChecked: $(this).is(':checked') },
            success: function (result) {

            }
        });
    });
});

not sure if it is being called

Still no JOY

Could you provide us your "Delete" method please

Joan Caron
– Joan Caron

2013-08-30 12:58:25 +00:00
Commented Aug 30, 2013 at 12:58 — Joan Caron
– Joan Caron, Commented Aug 30, 2013 at 12:58

Joan Caron · Accepted Answer · 2013-08-30 13:04:00Z

0

You only need to submit the form when the checkbox is checked.

answered Aug 30, 2013 at 13:04

Joan Caron

1,97018 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

roo Over a year ago

Thanks Joan. Sorry to appear so dumb but how?

Joan Caron Over a year ago

this link can help you stackoverflow.com/questions/9185606/…

roo · Accepted Answer · 2013-08-31 10:30:52Z

Thanks to Joan for pointing me in a constructive direction. I realized I needed some jQuery/Ajax to solve this and doing some more searching managed to get to a solution.

Used the following script in a js file

$(function () {
    $("input[type=checkbox]").click(function () {
        var data_id = $(this).data("id");
        $.ajax({
            url: 'Home/Edit',
            type: 'POST',
            data: { id: data_id, isChecked: $(this).is(':checked') },
            success: function (result) {

            }
        });
    });
});

changing the code in the view to:

@using (@Html.BeginForm())
{
    <table>
        @for (int i = 0; i < Model.Tasks.Count; i++)
        {
            <tr>
                <td>
                    @Html.CheckBoxFor(m => m.Tasks[i].IsDone, new { data_id=Model.Tasks[i].Id })
                </td>
                <td>
                    @Html.EditorFor(m => m.Tasks[i].Title)
                </td>
                <td>
                    @Html.ActionLink("Delete", "Delete", new { id = Model.Tasks[i].Id })
                </td>
            </tr>
        }
    </table>
}

Collectives™ on Stack Overflow

Can't get CheckBox to update model in MVC Razor Using Html.CheckBoxFor

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related