'SyntaxError' calling javascript function?

Question

Anyone know why Tool_AJAX.loadString("' + split[i] + '"); is not working?
Even though this line works fine ..

split[i] = 'Hello'

alert('Tool_AJAX.loadString("' + split[i] + '")');
Output: Tool_AJAX.loadString("Hello");

Heres the troublesome code ..

body += 
    '<tr>' +
        '<td><h4><a href="javascript:;" onclick="Tool_AJAX.loadString("' + split[i] + '");">' + split[i] + '</a></h4></td>' +
        '<td>Dummy</td>' +
        '<td>Dummy</td>' +
    '</tr>';


Error: SyntaxError: syntax error
Source File: http://localhost:8080/Tool/
Line: 1, Column: 32
Source Code:
Tool_AJAX.loadString(

Tool_AJAX is defined as ..

var Tool_AJAX = {
    loadString: function(string){

Andreas · Accepted Answer · 2013-09-02 12:36:18Z

1

'<td><h4><a href="javascript:;" onclick="Tool_AJAX.loadString("' + split[i] + '");">' + split[i] + '</a></h4></td>' +

This will end as

<td><h4><a href="javascript:;" onclick="Tool_AJAX.loadString("...");">...</a></h4></td>

The onclick-part is malformed because of the quotes.
If you can't separate the Javascript from the HTML use single quotes for the string between the brackets:

 '<td><h4><a href="javascript:;" onclick="Tool_AJAX.loadString(\'' + split[i] + '\');">' + split[i] + '</a></h4></td>' +

answered Sep 2, 2013 at 12:36

Andreas

21.9k7 gold badges52 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

cHao Over a year ago

I was in the middle of typing almost exactly this. :) +1

bobbyrne01 Over a year ago

This works perfect, thanks! The reason I'm embedding the HTML inside JavaScript is because its dymanic, I don't know how many <tr> elements will be loaded into the split array. Do you have a suggestion on how this separation could still be achieved given this constraint?

Andreas Over a year ago

I haven't talk about the HTML in the Javascript. I've talked about the inline handler for the onclick event. Why not add a click handler on the table instead of one for each row.

mvw · Accepted Answer · 2013-09-02 12:28:55Z

0

Try

Tool_AJAX.loadString("'" + split[i] + "'");

(Do you really need split[i] in quotes as argument?)

answered Sep 2, 2013 at 12:28

mvw

5,1151 gold badge30 silver badges36 bronze badges

Comments

Piyuesh · Accepted Answer · 2013-09-02 12:33:48Z

0

Try \"' + split[i] + '\". It should work.

answered Sep 2, 2013 at 12:33

Piyuesh

1,0561 gold badge9 silver badges18 bronze badges

1 Comment

cHao Over a year ago

Not quite. The problem isn't JavaScript; it's that HTML is interpreting the quotes. They need to be single quotes instead, or HTML-escaped like ", so they don't cut off the attribute value.

Collectives™ on Stack Overflow

'SyntaxError' calling javascript function?

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related