Java Inner Class Iterator Problem

Question

I'm having difficulty using an inner Iterator.

private List<List<? extends HasWord>> sentences = new ArrayList<List<? extends HasWord>>(); 
private Iterator<String> wordIterator = new Words();
private class Words implements Iterator<String> {

    int currSentence = 0;
    int currWord = 0;

    @Override
    public boolean hasNext() {
        return currSentence != sentences.size() - 1 && currWord != sentences.get(currSentence).size() - 1;
    }

    @Override
    public String next() {
        String nextWord = sentences.get(currSentence).get(currWord).word();
        currSentence++;
        currWord++;

        return nextWord;
    }

    @Override
    public void remove() {
        throw new UnsupportedOperationException();          
    }

}

Then, I try to iterate over it:

for (String s : wordIterator) { //Error: Can only iterate over an array or an instance of java.lang.Iterable
            words.add(s);

But it doesn't work. (See commented compiler error on the problematic line). What am I doing wrong here?

On an engineering note, do is the right way to solve my problem? I have a bunch of loops of this form:

    for (List<? extends HasWord> sent : sentences) {
        for (HasWord token : sent) {
            //do stuff
        }
        }

So I decided an Iterator would be cleaner. Is this overkill, or is there another way you'd do it?

score 5 · Accepted Answer · 2009-12-08 18:57:52Z

5

There's nothing fundamentally wrong with having two nested for loops to do this, but I think this would be cleaner:

public class Words implements Iterator<String> {
  private final Iterator<HasWord> sentences;
  private Iterator<String> currentSentence;

  public boolean hasNext() {
    return currentSentence.hasNext() || sentences.hasNext();
  }

  public String next() {
    if (currentSentence.hasNext()) {
      return currentSentence.next();
    }
    currentSentence = sentences.next();
    return next(); // will return the first word of the next sentence
  }
  //remove() omitted for brevity
}

Return a new instance of this class every time you need an iterator over several sentences, and initialize the sentences field using sentences.iterator();

(Edited after reading your question more carefully)

edited Dec 8, 2009 at 18:57

answered Dec 8, 2009 at 18:48

user8681

Sign up to request clarification or add additional context in comments.

1 Comment

user8681 Over a year ago

Note that you may have to add some additional checking if sentences can be empty.

james · Accepted Answer · 2009-12-08 20:51:18Z

3

private class Words implements Iterator<String>, Iterable<String> {
  ...
  public Iterator<String> iterator() {
    return this;
  }
  ...
}

answered Dec 8, 2009 at 20:51

james

1,3777 silver badges6 bronze badges

Collectives™ on Stack Overflow

Java Inner Class Iterator Problem

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related