java with postgresql mistake with statement

Question

I have tried to getting result from db about has done query,db always get me "false" even when that has trued.

oldPassword = DBConfig.MD5(oldPassword);  //thase are me own classes
newPassword = DBConfig.MD5(newPassword);  

String updatePassword = "UPDATE login " + "SET password='"
+ newPassword + "'" + " WHERE password='" + oldPassword
+ "' and employee_id=" + userId + " ;";

Connection con = DBConfig.dbConfigure();
Statement statement = con.createStatement();
boolean success = statement.execute(updatePassword);
LOGGER.info(success);
DBManager.close(con, statement, null); //I'm closing connectin,statmant and result set if that has

/********************/ DBConfig

    public static final String USER_NAME = "postgres";
public static final String PASSWORD = "password";
public static final String DB_NAME="jdbc:postgresql://localhost/myTask";
public static final String DB_DRIVER = "org.postgresql.Driver";

    public static Connection dbConfigure() throws ClassNotFoundException,
        SQLException {
    String userName = USER_NAME;

    String dbPassword = PASSWORD;
    String dbName = DB_NAME;
    String dbDriver = DB_DRIVER;

    Class.forName(dbDriver);
    Connection con = DriverManager.getConnection(dbName, userName,
            dbPassword);
    return con;
}

IMO you should not use password as part of the query, instead retrieve the user password and do a match in server side i.e. in Java, then do a clean update. Also, use PreparedStatements instead of plain Statements to avoid SQL Injection. — Luiggi Mendoza
– Luiggi Mendoza, Commented Sep 25, 2013 at 14:53
Also, use executeUpdate method instead of plain execute. — Luiggi Mendoza
– Luiggi Mendoza, Commented Sep 25, 2013 at 14:56

M Abbas · Accepted Answer · 2013-09-25 15:01:38Z

1

db always get me "false" even when that has trued.

From javadoc:

The execute method returns true if the first result is a ResultSet object; false if it is an update count or there are no results

edited Sep 25, 2013 at 15:01

answered Sep 25, 2013 at 14:55

M Abbas

6,4994 gold badges37 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shamim Ahmmed · Accepted Answer · 2013-09-25 14:59:37Z

0

You can try to use executeUpate. It is much more clear when you are doing INSERT, UPDATE, DELETE. It returns number of rows effected by this query.

answered Sep 25, 2013 at 14:59

Shamim Ahmmed

8,3836 gold badges28 silver badges37 bronze badges

Collectives™ on Stack Overflow

java with postgresql mistake with statement

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related