Why if else doesn't work here in javascript?

Question

I want an animation such that it toggles to slide the div left and right every time I click button. However, when I actually use the code it only slides it to right once and stops working any more.

<script> 
var left = 1;

$(document).ready(function(){
$("button").click(function(){

  if(left==1){
    $("div").animate({left:'250px'});
    left=2;
  }else{ 
    $("div").animate({right:'250px'});
    left=1;
  }

  });
});

</script>

What's wrong with this code? I couldn't think of a problem.

Belladonna · Accepted Answer · 2014-01-26 23:52:48Z

5

Because you're using both left and right, try this:

if( left === 1 ) {
    $("div").animate({left:'250px'});
    left = 2;
}
else { 
    $("div").animate({left:'0px'});
    left = 1;
}

edited Jan 26, 2014 at 23:52

answered Oct 1, 2013 at 19:35

Belladonna

3,8622 gold badges26 silver badges33 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

bfavaretto Over a year ago

Or clear the left: $("div").animate({left:'',right:'250px'});. jsbin.com/OCigILU/1/edit

Dung Tran · Accepted Answer · 2013-10-01 19:46:13Z

0

The loop was right, but the css wasn't.

<script> 
var left = 1;

$(document).ready(function(){
$("button").click(function(){
  if(left==1){
    $("div").animate({left:'250px'});
    left=2;
  }
  else { 
    $("div").animate({left:'0px'});
    left=1;
  }
 });
});

</script>

answered Oct 1, 2013 at 19:46

Dung Tran

1187 bronze badges

Collectives™ on Stack Overflow

Why if else doesn't work here in javascript?

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related