Create JSON string with php issue

Question

I want to create a JSON with this structure:

{"id":"ws",
 "data":[
   {"name":"it.geosolutions"},
   {"name":"cite"},
   {"name":"testwor"},
   {"name":"tiger"},
   {"name":"sde"},
   {"name":"topp"},
   {"name":"newwork"},
   {"name":"sf"},
   {"name":"nurc"}
 ]
}

I do:

function funcArray(){
 foreach ($ws as $item){
  $wsarray[] = '{"name":"'.$item->name.'"}';
 }  
 return $wsarray;
}

$json_data = array ('id'=>'ws','data'=>funcArray());
$json = json_encode($json_data);

And i get:

{"id":"ws",
 "data":[
   "{\"name\":\"it.geosolutions\"}",
   "{\"name\":\"cite\"}",
   "{\"name\":\"testwor\"}",
   "{\"name\":\"tiger\"}",
   "{\"name\":\"sde\"}",
   "{\"name\":\"topp\"}",
   "{\"name\":\"newwork\"}",
   "{\"name\":\"sf\"}",
   "{\"name\":\"nurc\"}"
  ]
}

How to repair it?

UPDATE

I was tried this:

function funcArray(){
 foreach ($ws as $item){
   $wsarray[] = json_encode(array('name'=>$item->name));
 }  
 return $wsarray;
}

But get:

{"id":"ws","data":["{\"name\":\"it.geosolutions\"}","{\"name\":\"cite\"}","{\"name\":\"testwor\"}","{\"name\":\"tiger\"}","{\"name\":\"sde\"}","{\"name\":\"topp\"}","{\"name\":\"newwork\"}","{\"name\":\"sf\"}","{\"name\":\"nurc\"}"]}

Whats wrong?

maček · Accepted Answer · 2013-10-07 16:08:22Z

8

Don't build JSON this way. Use json_encode on a PHP array instead.

$arr = array(
"id" => "ws",
"data" => array(
  array("name" => "it.geosolutions"),
  array("name" => "cite"),
  array("name" => "testwor"),
  array("name" => "tiger"),
  array("name" => "sde"),
  array("name" => "topp"),
  array("name" => "newwork"),
  array("name" => "sf"),
  array("name" => "nurc")
));

echo json_encode($arr);

Output

{"id":"ws","data":[{"name":"it.geosolutions"},{"name":"cite"},{"name":"testwor"},{"name":"tiger"},{"name":"sde"},{"name":"topp"},{"name":"newwork"},{"name":"sf"},{"name":"nurc"}]}

To work with your $ws array, you can probably do something like this:

echo json_data(array(
  "id" => "ws",
  "data" => array_map(function($item) { return array("name" => $item->name); }, $ws)
));

Note using array_map like this requires >= PHP 5.3

edited Oct 7, 2013 at 16:08

answered Oct 7, 2013 at 7:16

maček

78k37 gold badges172 silver badges200 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Amal Over a year ago

Clever use of array_map, +1.

Nes · Accepted Answer · 2013-10-07 07:19:31Z

1

You need to create a array first then use json_encode to create json output. Dont hard code any json there..

answered Oct 7, 2013 at 7:19

Nes

3041 silver badge10 bronze badges

Comments

plain jane · Accepted Answer · 2013-10-07 07:24:49Z

1

Instead of building the json string in the function funcArray why not build an array and return it

function funcArray(){
   foreach ($ws as $item){
       $wsarray[] = array("name"=>$item->name);
    }  
    return $wsarray;
  }

 $json_data = array ('id'=>'ws','data'=>funcArray());
 $json = json_encode($json_data);

answered Oct 7, 2013 at 7:24

plain jane

1,0081 gold badge8 silver badges19 bronze badges

Collectives™ on Stack Overflow

Create JSON string with php issue

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related